Skip to content

Conversation

ahmadehsas
Copy link

@ahmadehsas ahmadehsas commented Sep 2, 2025

-->

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR:

I have completed all the mandatory tasks.

Questions

ahmadehsas and others added 12 commits May 18, 2025 13:22
…d column next to the second. create footer and do some CSS style.
The " blah" text is deleted successfully.
… the footer acceptance criteria.i added borders to "Read more".
…idation.

accessibility: update image alt text and heading levels
style: remove trailing slashes from void elements for W3C compliance.
…esponsive CSS grid; cleaned up and finalized styles
…ty of content and fixed the footer to the bottom of the view point.
Copy link

netlify bot commented Sep 2, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 2f677bc
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/68b76c54b582de0008088578
😎 Deploy Preview https://deploy-preview-741--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (🔴 down 4 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented Sep 2, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

@ahmadehsas ahmadehsas added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 2, 2025
Copy link

github-actions bot commented Sep 2, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

4 similar comments
Copy link

github-actions bot commented Sep 2, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

Copy link

github-actions bot commented Sep 2, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

Copy link

github-actions bot commented Sep 2, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

Copy link

github-actions bot commented Sep 2, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

@ahmadehsas ahmadehsas changed the title Westmidland | Sep-2025 | Ahmad Ehsas | Wireframe Westmidland Sep-2025 Ahmad Ehsas Wireframe Sep 2, 2025
Copy link

github-actions bot commented Sep 2, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

@ahmadehsas ahmadehsas changed the title Westmidland Sep-2025 Ahmad Ehsas Wireframe Westmidland | ITP-Sep-2025 | Ahmad Ehsas | Sprint-1 | Wireframe Sep 2, 2025
Copy link

github-actions bot commented Sep 2, 2025

Your PR's title didn't contain a known region.

Please check the expected title format, and make sure your region is in the correct place and spelled correctly.

@ahmadehsas ahmadehsas changed the title Westmidland | ITP-Sep-2025 | Ahmad Ehsas | Sprint-1 | Wireframe West Midlands | ITP-Sep-2025 | Ahmad Ehsas | Sprint-1 | Wireframe Sep 2, 2025
Copy link

github-actions bot commented Sep 2, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-1) doesn't match expected format (example: 'Sprint 2', without quotes)

@ahmadehsas ahmadehsas changed the title West Midlands | ITP-Sep-2025 | Ahmad Ehsas | Sprint-1 | Wireframe West Midlands | ITP-Sep-2025 | Ahmad Ehsas | Sprint1 | Wireframe Sep 2, 2025
Copy link

github-actions bot commented Sep 2, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint1) doesn't match expected format (example: 'Sprint 2', without quotes)

@ahmadehsas ahmadehsas changed the title West Midlands | ITP-Sep-2025 | Ahmad Ehsas | Sprint1 | Wireframe West Midlands | ITP-Sep-2025 | Ahmad Ehsas | Sprint 1 | Wireframe Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant