West Midlands | 25-ITP-Sep | Baba Yusuf | Sprint 3 | coursework/sprint-3-implement-and-rewrite

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -10,9 +10,21 @@
 function getAngleType(angle) {
   if (angle === 90) {
     return "Right angle";
+  } else if (angle < 90) {
+    return "Acute angle";
+  } else if (angle > 90 && angle < 180) {
+    return "Obtuse angle";
+  } else if (angle === 180) {
+    return "Straight angle";
+  } else if (angle > 180 && angle < 360) {
+    return "Reflex angle";
+  } else if (angle === 360) {
+    return "Complete angle";
+  } else {
+    return "Invalid angle";
   }
-   // Run the tests, work out what Case 2 is testing, and implement the required code here.
-   // Then keep going for the other cases, one at a time.
+  // Run the tests, work out what Case 2 is testing, and implement the required code here.
+  // Then keep going for the other cases, one at a time.
 }
 
 // The line below allows us to load the getAngleType function into tests in other files.
@@ -50,14 +62,18 @@ assertEquals(acute, "Acute angle");
 // When the angle is greater than 90 degrees and less than 180 degrees,
 // Then the function should return "Obtuse angle"
 const obtuse = getAngleType(120);
+assertEquals(obtuse, "Obtuse angle");
 // ====> write your test here, and then add a line to pass the test in the function above
 
 // Case 4: Identify Straight Angles:
 // When the angle is exactly 180 degrees,
 // Then the function should return "Straight angle"
 // ====> write your test here, and then add a line to pass the test in the function above
-
+const straight = getAngleType(180);
+assertEquals(straight, "Straight angle");
 // Case 5: Identify Reflex Angles:
 // When the angle is greater than 180 degrees and less than 360 degrees,
 // Then the function should return "Reflex angle"
-// ====> write your test here, and then add a line to pass the test in the function above
+// ====> write your test here, and then add a line to pass the test in the function above
+const reflex = getAngleType(359);
+assertEquals(reflex, "Reflex angle");

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -8,8 +8,12 @@
 // write one test at a time, and make it pass, build your solution up methodically
 
 function isProperFraction(numerator, denominator) {
-  if (numerator < denominator) {
+  if (denominator === 0) {
+    return "Invalid — denominator cannot be zero";
+  } else if (numerator * numerator < denominator * denominator) {
     return true;
+  } else {
+    return false;
   }
 }
 
@@ -46,14 +50,35 @@ assertEquals(improperFraction, false);
 // target output: true
 // Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
 const negativeFraction = isProperFraction(-4, 7);
+assertEquals(negativeFraction, true);
 // ====> complete with your assertion
 
 // Equal Numerator and Denominator check:
 // Input: numerator = 3, denominator = 3
 // target output: false
 // Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
 const equalFraction = isProperFraction(3, 3);
+assertEquals(equalFraction, false);
 // ====> complete with your assertion
 
 // Stretch:
 // What other scenarios could you test for?
+//Stretch 1 - Zero numerator
+const zeroNumerator = isProperFraction(0, 5);
+assertEquals(zeroNumerator, true);
+
+//Stretch 2 - Negative denominator
+const negativeDenominator = isProperFraction(4, -7);
+assertEquals(negativeDenominator, true);
+
+//Stretch 3 - Both numerator and denominator negative
+const bothNegative = isProperFraction(-2, -3);
+assertEquals(bothNegative, true);
+
+//Stretch 4 - Zero denominator (edge case)
+const zeroDenominator = isProperFraction(3, 0);
+assertEquals(zeroDenominator, "Invalid — denominator cannot be zero");
+
+//Stretch 5 - Both numerator and denominator negative (numerator absolute value > denominator absolute value)
+const bothNegative2 = isProperFraction(-5, -3);
+assertEquals(bothNegative2, false);

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -8,8 +8,20 @@
 // write one test at a time, and make it pass, build your solution up methodically
 // just make one change at a time -- don't rush -- programmers are deep and careful thinkers
 function getCardValue(card) {
+  const rank = card.slice(0, -1);
+
   if (rank === "A") {
     return 11;
+  } else if (rank === "K" || rank === "Q" || rank === "J" || rank === "10") {
+    return 10;
+  } else {
+    const numericRank = parseInt(rank, 10);
+
+    if (!isNaN(numericRank) && numericRank >= 2 && numericRank <= 9) {
+      return numericRank;
+    } else {
+      throw new Error(`Invalid or unrecognized card rank: "${rank}"`);
+    }
   }
 }
 
@@ -39,6 +51,7 @@ assertEquals(aceofSpades, 11);
 // When the function is called with such a card,
 // Then it should return the numeric value corresponding to the rank (e.g., "5" should return 5).
 const fiveofHearts = getCardValue("5♥");
+assertEquals(fiveofHearts, 5);
 // ====> write your test here, and then add a line to pass the test in the function above
 
 // Handle Face Cards (J, Q, K):
@@ -55,3 +68,26 @@ const fiveofHearts = getCardValue("5♥");
 // Given a card with an invalid rank (neither a number nor a recognized face card),
 // When the function is called with such a card,
 // Then it should throw an error indicating "Invalid card rank."
+//Stretch (personal)
+// Handle Face Cards (J, Q, K):
+const kingOfClubs = getCardValue("K♣");
+assertEquals(kingOfClubs, 10);
+
+const queenOfDiamonds = getCardValue("Q♦");
+assertEquals(queenOfDiamonds, 10);
+
+const jackOfSpades = getCardValue("J♠");
+assertEquals(jackOfSpades, 10);
+
+const tenOfHearts = getCardValue("10♥");
+assertEquals(tenOfHearts, 10);
+// Handle Invalid Cards:
+try {
+  getCardValue("Z♠");
+  console.assert(false, "Expected an error for invalid card rank");
+} catch (error) {
+  console.assert(
+    error.message === 'Invalid or unrecognized card rank: "Z"',
+    `Expected error message 'Invalid or unrecognized card rank: "Z"', got "${error.message}"`
+  );
+}

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -12,15 +12,24 @@ test("should identify right angle (90°)", () => {
 // Case 2: Identify Acute Angles:
 // When the angle is less than 90 degrees,
 // Then the function should return "Acute angle"
-
+test("should identify acute angle (< 90°)", () => {
+  expect(getAngleType(89)).toEqual("Acute angle");
+});
 // Case 3: Identify Obtuse Angles:
 // When the angle is greater than 90 degrees and less than 180 degrees,
 // Then the function should return "Obtuse angle"
-
+test("should identify obtuse angle (> 90° && < 180°)", () => {
+  expect(getAngleType(91)).toEqual("Obtuse angle");
+});
 // Case 4: Identify Straight Angles:
 // When the angle is exactly 180 degrees,
 // Then the function should return "Straight angle"
-
+test("should identify straight angle (180°)", () => {
+  expect(getAngleType(180)).toEqual("Straight angle");
+});
 // Case 5: Identify Reflex Angles:
 // When the angle is greater than 180 degrees and less than 360 degrees,
 // Then the function should return "Reflex angle"
+test("should identify reflex angle (>180° && < 360°)", () => {
+  expect(getAngleType(359)).toEqual("Reflex angle");
+});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -2,12 +2,26 @@
 // We will use the same function, but write tests for it using Jest in this file.
 const isProperFraction = require("../implement/2-is-proper-fraction");
 
-test("should return true for a proper fraction", () => {
+test("should return true for a proper fraction (numerator < denominator)", () => {
   expect(isProperFraction(2, 3)).toEqual(true);
 });
 
 // Case 2: Identify Improper Fractions:
-
+test("should return false for an improper fraction (numerator > denominator)", () => {
+  expect(isProperFraction(5, 3)).toEqual(false);
+});
 // Case 3: Identify Negative Fractions:
-
+test("should return true for a negative proper fraction", () => {
+  expect(isProperFraction(-1, 4)).toEqual(true);
+  expect(isProperFraction(1, -4)).toEqual(true);
+  expect(isProperFraction(-1, -4)).toEqual(true);
+});
+test("should return false for a negative improper fraction", () => {
+  expect(isProperFraction(4, -3)).toEqual(false);
+  expect(isProperFraction(5, -4)).toEqual(false);
+  expect(isProperFraction(-5, 4)).toEqual(false);
+});
 // Case 4: Identify Equal Numerator and Denominator:
+test("should return false when numerator and denominator are equal", () => {
+  expect(isProperFraction(5, 5)).toEqual(false);
+});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -8,6 +8,50 @@ test("should return 11 for Ace of Spades", () => {
 });
 
 // Case 2: Handle Number Cards (2-10):
+test("should return correct value for number cards (2–10)", () => {
+  expect(getCardValue("2♥")).toEqual(2);
+  expect(getCardValue("7♣")).toEqual(7);
+  expect(getCardValue("10♦")).toEqual(10);
+  expect(getCardValue("5♠")).toEqual(5);
+});
 // Case 3: Handle Face Cards (J, Q, K):
+test("should return 10 for face cards (J, Q, K)", () => {
+  expect(getCardValue("J♠")).toEqual(10);
+  expect(getCardValue("Q♦")).toEqual(10);
+  expect(getCardValue("K♥")).toEqual(10);
+  expect(getCardValue("J♣")).toEqual(10);
+});
 // Case 4: Handle Ace (A):
+test("should return 11 for Ace cards", () => {
+  expect(getCardValue("A♦")).toEqual(11);
+  expect(getCardValue("A♥")).toEqual(11);
+  expect(getCardValue("A♣")).toEqual(11);
+  expect(getCardValue("A♠")).toEqual(11);
+});
 // Case 5: Handle Invalid Cards:
+test("should throw an error for invalid card ranks and provide a descriptive message", () => {
+  // These specific ranks are all invalid
+  expect(() => getCardValue("Z♠")).toThrow(
+    'Invalid or unrecognized card rank: "Z"'
+  );
+  expect(() => getCardValue("1♥")).toThrow(
+    'Invalid or unrecognized card rank: "1"'
+  );
+  expect(() => getCardValue("11♦")).toThrow(
+    'Invalid or unrecognized card rank: "11"'
+  );
+  expect(() => getCardValue("X♣")).toThrow(
+    'Invalid or unrecognized card rank: "X"'
+  );
+
+  // These should throw because they result in an empty or whitespace rank
+  expect(() => getCardValue(" ♣")).toThrow(
+    'Invalid or unrecognized card rank: " "'
+  );
+  expect(() => getCardValue("♣")).toThrow(
+    'Invalid or unrecognized card rank: ""'
+  );
+  expect(() => getCardValue("")).toThrow(
+    'Invalid or unrecognized card rank: ""'
+  );
+});