West Midlands | 25 Sep ITP | Iswat Bello | Sprint 3 | Implement and rewrite tests

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -7,27 +7,33 @@
 // complete the rest of the tests and cases
 // write one test at a time, and make it pass, build your solution up methodically
 
+function isProperFraction(numerator, denominator) {
+  // Invalid input: must be integers
+  if (!Number.isInteger(numerator) || !Number.isInteger(denominator)) {
+    return false;
+  }
 
+  // Denominator cannot be zero
+  if (denominator === 0) {
+    return false;
+  }
 
-function isProperFraction(numerator, denominator) {
-  let actualOutput;
-  // Denominator must be positive
-  if (denominator <= 0) {
-    actualOutput = false;
+  // Numerator cannot be zero
+  if (numerator === 0) {
+    return false;
   }
-  // Numerator must be positive and smaller than denominator
-  else if (numerator > 0 && numerator < denominator) {
-    actualOutput = true;
+
+  // Proper fraction: absolute numerator smaller than absolute denominator
+  if (Math.abs(numerator) < Math.abs(denominator)) {
+    return true;
   }
+
   // All other cases are not proper fractions
-  else {
-    actualOutput = false;
-  }
-  return actualOutput;
+  return false;
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
-// This will be useful in the "rewrite tests with jest" step.
+// This will be useful in the "rewrite tests with jest" step
 module.exports = isProperFraction;
 
 // here's our helper again
@@ -60,7 +66,7 @@ assertEquals(improperFraction, false);
 // Explanation: Negative numerator should not count as proper fraction.
 const negativeFraction = isProperFraction(-4, 7);
 // ====> complete with your assertion
-assertEquals(negativeFraction, false);
+assertEquals(negativeFraction, true);
 
 // Equal Numerator and Denominator check:
 // Input: numerator = 3, denominator = 3
@@ -85,18 +91,67 @@ assertEquals(zeroNumerator, false);
 // Target output: false
 // Explanation: Denominator must be positive for a proper fraction.
 const negativeDenominator = isProperFraction(3, -5);
-assertEquals(negativeDenominator, false);
+assertEquals(negativeDenominator, true);
 
 // Both Negative check:
 // Input: numerator = -2, denominator = -3
 // Target output: false
 // Explanation: Proper fractions must have positive numerator and denominator.
 const bothNegative = isProperFraction(-2, -3);
-assertEquals(bothNegative, false);
+assertEquals(bothNegative, true);
 
 // Zero Denominator check:
 // Input: numerator = 1, denominator = 0
 // Target output: false
 // Explanation: Division by zero is invalid; fraction cannot be proper.
 const zeroDenominator = isProperFraction(1, 0);
 assertEquals(zeroDenominator, false);
+
+// Float Numerator check:
+// Input: numerator = 2.5, denominator = 3
+// Target output: false
+// Explanation: Fractions with a non-integer numerator are not considered proper fractions.
+const floatNumerator = isProperFraction(2.5, 3);
+assertEquals(floatNumerator, false);
+
+// Float Denominator check:
+// Input: numerator = 2, denominator = 3.5
+// Target output: false
+// Explanation: Fractions with a non-integer denominator are invalid and should not be considered proper fractions.
+const floatDenominator = isProperFraction(2, 3.5);
+assertEquals(floatDenominator, false);
+
+// Both Numerator and Denominator as Floats check:
+// Input: numerator = 1.5, denominator = 2.5
+// Target output: false
+// Explanation: Fractions with both numerator and denominator as floats are invalid and should not be considered proper fractions.
+const floatBoth = isProperFraction(1.5, 2.5);
+assertEquals(floatBoth, false);
+
+// Large Number check:
+// Input: numerator = 99, denominator = 100
+// Target output: true
+// Explanation: 99/100 is a valid proper fraction, even with large values.
+const largeNumbers = isProperFraction(99, 100);
+assertEquals(largeNumbers, true);
+
+// Negative Zero check:
+// Input: numerator = -0, denominator = 5
+// Target output: false
+// Explanation: Negative zero is equivalent to zero; not a proper fraction.
+const negativeZero = isProperFraction(-0, 5);
+assertEquals(negativeZero, false);
+
+// Denominator less than -1 check:
+// Input: numerator = 1, denominator = -1
+// Target output: false
+// Explanation: Equal magnitude makes it improper, regardless of sign.
+const negOneDenominator = isProperFraction(1, -1);
+assertEquals(negOneDenominator, false);
+
+// Proper Fraction check:
+// Input: numerator = 2, denominator = 4
+// Target output: true
+// Explanation: 2/4 is a proper fraction because the absolute value of the numerator is less than the absolute value of the denominator.
+const twoOverFour = isProperFraction(2, 4);
+assertEquals(twoOverFour, true);

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -13,7 +13,7 @@ test("should return false for improper fractions", () => {
 
 // Case 3: Identify Negative Fractions:
 test("should return false for negative fractions", () => {
-  expect(isProperFraction(-4, 9)).toEqual(false);
+  expect(isProperFraction(-4, 9)).toEqual(true);
 })
 
 // Case 4: Identify Equal Numerator and Denominator: