NW | 25-ITP_Sep | Ahmad Hmedan | Sprint 3 | implement and rewrite tests

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -9,7 +9,7 @@
 
 function isProperFraction(numerator, denominator) {
   if (denominator === 0) return false;
-  if (numerator < 1) numerator = numerator * -1;
+  if (numerator < 1) numerator = Math.abs(numerator) ;
   if (denominator < 1) denominator = Math.abs(denominator);
 
   if (numerator < denominator) {

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -15,12 +15,11 @@ function getCardValue(card) {
   if (rank === "J" || rank === "Q" || rank === "K") {
     return 10;
   }
-  const convertTheStringtoNumber = Number(rank);
-  if (convertTheStringtoNumber >= 2 && convertTheStringtoNumber <= 10) {
-    return convertTheStringtoNumber;
-  } else {
-    return "Invalid card rank";
-  }
+
+  const validRank = ["2", "3", "4", "5", "6", "7", "8", "9", "10"];
+  if (validRank.includes(rank)) {
+    return Number(rank);
+  } else return "Invalid card rank";
 }
 // The line below allows us to load the getCardValue function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -18,3 +18,14 @@ test("returns true for a negative proper fraction( absolute value of the numerat
 test("returns false when numerator equals denominator", () => {
   expect(isProperFraction(9, 9)).toEqual(false);
 });
+
+test("return false when  numerator equals denominator when both are negative", () => {
+  expect(isProperFraction(-4, -4)).toEqual(false);
+});
+
+test("returns false for a negative proper fraction( absolute value of the denominator is less than the numerator)", () => {
+  expect(isProperFraction(-7, 4)).toEqual(false);
+});
+test("returns false when denominator is zero", () => {
+  expect(isProperFraction(3, 0)).toEqual(false);
+});