Skip to content

fix(selectdropdown): fixes tests with fresh git history#2992

Merged
codecademydev merged 2 commits intomainfrom
ajr-selectdropdown-fix
Jan 6, 2025
Merged

fix(selectdropdown): fixes tests with fresh git history#2992
codecademydev merged 2 commits intomainfrom
ajr-selectdropdown-fix

Conversation

@dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Dec 13, 2024 •
edited by aresnik11
Loading

Overview

Duplicate of #2988 minus the extra git history from sb upgrade

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env
Another Repo Another Link Another Env

@nx-cloud
Copy link

nx-cloud bot commented Dec 13, 2024 •
edited
Loading

View your CI Pipeline Execution ↗ for commit c6ff056.

☁️ Nx Cloud last updated this comment at 2025-01-02 17:43:27 UTC

@LinKCoding LinKCoding changed the title (amy) - selectdropdown fixes with fresh git history fix(selectdropdown): fixes tests with fresh git history Jan 2, 2025
@codecademydev
Copy link
Collaborator

codecademydev commented Jan 2, 2025

🚀 Styleguide deploy preview ready!

https://6776cffa1ac73169e60a9f1f--gamut-preview.netlify.app

Deploy Logs

@codecademydev
Copy link
Collaborator

codecademydev commented Jan 2, 2025

📬Published Alpha Packages:

@codecademy/gamut@57.6.2-alpha.c6ff05.0
@codecademy/gamut-kit@0.6.458-alpha.c6ff05.0

@aresnik11 aresnik11 marked this pull request as ready for review January 6, 2025 14:26
@aresnik11 aresnik11 requested a review from a team as a code owner January 6, 2025 14:26
LinKCoding
LinKCoding approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@LinKCoding LinKCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@LinKCoding LinKCoding added the Ship It :shipit: Automerge this PR when possible label Jan 6, 2025
@codecademydev codecademydev merged commit 753eaec into main Jan 6, 2025
17 of 18 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Jan 6, 2025
@codecademydev codecademydev deleted the ajr-selectdropdown-fix branch January 6, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LinKCoding LinKCoding LinKCoding approved these changes

@BandanaKM BandanaKM Awaiting requested review from BandanaKM BandanaKM is a code owner automatically assigned from Codecademy/gamut

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dreamwasp @codecademydev @LinKCoding @aresnik11