feat(borderColors): adding semantic and colormode compatible colors for borderColor#3004
Merged
codecademydev merged 11 commits intomainfrom Jan 14, 2025
Merged
feat(borderColors): adding semantic and colormode compatible colors for borderColor#3004codecademydev merged 11 commits intomainfrom
codecademydev merged 11 commits intomainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit 44f1e75. ☁️ Nx Cloud last updated this comment at |
aresnik11
reviewed
Jan 13, 2025
LinKCoding
commented
Jan 13, 2025
aresnik11
approved these changes
Jan 13, 2025
Contributor
aresnik11
left a comment
There was a problem hiding this comment.
Everything looks good and works great!!!
aresnik11
reviewed
Jan 13, 2025
Collaborator
📬Published Alpha Packages:@codecademy/gamut@57.6.5-alpha.44f1e7.0 |
Collaborator
|
🚀 Styleguide deploy preview ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add semantic border colors to colormode
PR Checklist
Testing Instructions
Note:
'navy','navy-800','secondary', and'text'are the same. So borderColors that used any of these named colors got updated toborder-primary.see: https://github.com/Codecademy/gamut/blob/main/packages/gamut-styles/src/variables/colors.ts#L44
and: https://github.com/Codecademy/gamut/blob/main/packages/gamut-styles/src/themes/core.ts#L75-L76
same idea for other named colors like
text-secondary==>border-secondary.and
text-disabled==>border-disabled.Gamut testing instructions:
border-primary,border-secondary,border-tertiary, andborder-disabledhave been added for both light and dark mode.border: 1orborder: 2shorthand, e.g. Badge (tertiary)Mono/Portal-App testing instructions:
Monolith/Codecademy testing instructions:
PR Links and Envs