Skip to content

fix(ProgressBar): adds focus outline#3006

Merged
codecademydev merged 4 commits intomainfrom
ajr-progress-bar-focus-outline
Feb 5, 2025
Merged

fix(ProgressBar): adds focus outline#3006
codecademydev merged 4 commits intomainfrom
ajr-progress-bar-focus-outline

Conversation

@aresnik11
Copy link
Contributor

@aresnik11 aresnik11 commented Jan 15, 2025

Overview

Updates ProgressBar to show focus outline for screenreader only text.

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GM-953,GM-545
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Note: please test locally, there's some weirdness with storybook previews

  1. Open the storybook preview and go to ProgressBar
  2. Open VoiceOver
  3. Navigate through the page and confirm there is visible keyboard focus when Progress: X% figure is read aloud
  4. See mono PR for testing instructions there. Any uses of ProgressBar in monolith are dead code.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Mono Mono Link Mono Env

@nx-cloud
Copy link

nx-cloud bot commented Jan 15, 2025

View your CI Pipeline Execution ↗ for commit e93a6f9.


☁️ Nx Cloud last updated this comment at 2025-02-04 18:11:41 UTC

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://67a2527408ba7e55ccb9db6f--gamut-preview.netlify.app

Deploy Logs

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/gamut@59.0.1-alpha.e93a6f.0
@codecademy/gamut-kit@0.6.470-alpha.e93a6f.0

@aresnik11 aresnik11 marked this pull request as ready for review February 4, 2025 20:44
@aresnik11 aresnik11 requested a review from a team as a code owner February 4, 2025 20:44
Copy link
Contributor

@LinKCoding LinKCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and works great!

@aresnik11 aresnik11 added the Ship It :shipit: Automerge this PR when possible label Feb 5, 2025
@codecademydev codecademydev merged commit d12d013 into main Feb 5, 2025
28 of 29 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Feb 5, 2025
@codecademydev codecademydev deleted the ajr-progress-bar-focus-outline branch February 5, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants