Conversation
|
View your CI Pipeline Execution ↗ for commit d8306d5. ☁️ Nx Cloud last updated this comment at |
jrood
force-pushed
the
jrood.upgrade-framer-motion
branch
from
be8bde6 to
c3fba76
Compare
jrood
force-pushed
the
jrood.upgrade-framer-motion
branch
3 times, most recently
from
7bf66a5 to
e15d183
Compare
jrood
force-pushed
the
jrood.upgrade-framer-motion
branch
2 times, most recently
from
b543fa0 to
b38f473
Compare
jrood
force-pushed
the
jrood.upgrade-framer-motion
branch
from
b38f473 to
7a3378f
Compare
jrood
force-pushed
the
jrood.upgrade-framer-motion
branch
from
7a3378f to
ce88cb5
Compare
Collaborator
📬Published Alpha Packages:@codecademy/gamut@59.0.6-alpha.d8306d.0 |
dreamwasp
approved these changes
Feb 11, 2025
Contributor
dreamwasp
left a comment
dreamwasp
left a comment
There was a problem hiding this comment.
looks good, thanks for doing this!
Collaborator
|
🚀 Styleguide deploy preview ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
11.18.0motion()tomotion.create()hrefprop forPaginationButtonto satisfy typescript since it can render as an anchor or button.Testing Instructions
There should be no functional changes.
As a smoke test, check Drawer and the "Animation" example for Popover.
PR Links and Envs