Closed
Conversation
|
View your CI Pipeline Execution ↗ for commit d9df27a. ☁️ Nx Cloud last updated this comment at |
Collaborator
📬Published Alpha Packages:eslint-plugin-gamut@2.3.1-alpha.d9df27.0 |
Collaborator
|
🚀 Styleguide deploy preview ready! |
dreamwasp
reviewed
Jan 21, 2025
Comment on lines
+30
to
+31
| const { expandable, selectable, onSelect, onFilter, onSort, prefixId } = | ||
| useControlContext(); |
Contributor
There was a problem hiding this comment.
some of these fixes seems a little off to me (including this one). i'll take a look at what changed + chat with the broader web plat team, def something we just inadvertently changed during the gamut migration
dreamwasp
requested changes
Jan 21, 2025
Contributor
dreamwasp
left a comment
dreamwasp
left a comment
There was a problem hiding this comment.
need to make some adjustments to format rules, there were some inadvertent changes during the gamut migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
No changes aside from running
yarn format. We had a number of files that were apparently written prior to the current format configuration.