refactor(RadialProgress): Remove scss#3010
Merged
codecademydev merged 3 commits intomainfrom Feb 5, 2025
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit f40952d. ☁️ Nx Cloud last updated this comment at |
Collaborator
|
🚀 Styleguide deploy preview ready! |
Collaborator
📬Published Alpha Packages:@codecademy/gamut@59.0.1-alpha.f40952.0 |
aresnik11
requested review from
BandanaKM,
LinKCoding,
dreamwasp and
timjenkins
and removed request for
BandanaKM and
timjenkins
dreamwasp
approved these changes
Feb 4, 2025
Comment on lines
+27
to
+34
| const RadialProgressWrapper = styled.figure<{ size: number | string }>( | ||
| ({ size }) => | ||
| css({ | ||
| position: 'relative', | ||
| height: size, | ||
| width: size, | ||
| }) | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Refactors
RadialProgressto use styled components instead of scss files.PR Checklist
Testing Instructions
Note: please test locally, there's some weirdness with storybook previews
Look at the
RadialProgressstory and confirm it looks the same.See mono PR for testing instructions there. Any uses of
RadialProgressin monolith are dead code.PR Links and Envs