feat(TagCelebration): ✨ A new illustration for the upcoming trial cancellation incentive#3011
Merged
codecademydev merged 2 commits intomainfrom Jan 22, 2025
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit 0642e96. ☁️ Nx Cloud last updated this comment at |
dreamwasp
reviewed
Jan 21, 2025
|
|
||
| import { IllustrationProps } from './types'; | ||
|
|
||
| export const TagCelebation: React.FC<IllustrationProps> = ({ |
Collaborator
📬Published Alpha Packages:@codecademy/gamut@57.7.2-alpha.0642e9.0 |
Collaborator
|
🚀 Styleguide deploy preview ready! |
zippyzow
requested review from
a team,
LinKCoding,
jakemhiller,
medhatnar and
saghdaey
and removed request for
a team and
medhatnar
dreamwasp
approved these changes
Jan 22, 2025
Contributor
dreamwasp
left a comment
dreamwasp
left a comment
There was a problem hiding this comment.
i tested this locally and it looks good. there's something up with the netlify build process that i've added to the gamut backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add offer card illustration to gamut-illustrations to be used for the upcoming trial cancellation incentive.
PR Checklist
Testing Instructions
Navigate to storybook to see new illustration called
TagCelebration.Update: Storybook not updating (ticket created to investigate issue). You will have to pull this branch down locally to see.
PR Links and Envs