fix(Tip): Fixes hover gap and click issues with ToolTips and PreviewTips#3018
Merged
codecademydev merged 15 commits intomainfrom Jan 31, 2025
Merged
fix(Tip): Fixes hover gap and click issues with ToolTips and PreviewTips#3018codecademydev merged 15 commits intomainfrom
codecademydev merged 15 commits intomainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit 9406a9d. ☁️ Nx Cloud last updated this comment at |
dreamwasp
changed the title
LinKCoding
reviewed
Jan 29, 2025
| }, | ||
| }); | ||
|
|
||
| const borderStyles = { borderColor: 'secondary', border: 1 } as const; |
Contributor
There was a problem hiding this comment.
I don't think you need borderColor: 'secondary'
border: 1 should already be: 1px solid ${colors['border-primary']}
see: https://github.com/Codecademy/gamut/blob/main/packages/gamut-styles/src/themes/core.ts
and border-primary and secondary both use navy-800
Contributor
Author
There was a problem hiding this comment.
good eye! will fix
* fix: ToolTip single word wrap * fixed it * fix floating tip * revert test code
Collaborator
📬Published Alpha Packages:@codecademy/gamut@57.7.4-alpha.9406a9.0 |
Collaborator
|
🚀 Styleguide deploy preview ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix hover gap and click tooltip bugs on
floatingtooltipsPR Checklist
Testing Instructions
/docs/molecules-tips-tooltip--docs#floating-placementPR Links and Envs