Skip to content

feat(Illustration): added new stackedPagesVariantIllustration#3020

Merged
codecademydev merged 2 commits intomainfrom
lh-stacked-pages-variant-illus
Feb 3, 2025
Merged

feat(Illustration): added new stackedPagesVariantIllustration#3020
codecademydev merged 2 commits intomainfrom
lh-stacked-pages-variant-illus

Conversation

@linseyjayne
Copy link
Contributor

@linseyjayne linseyjayne commented Jan 29, 2025

Overview

Added a variant stacked pages illustration to gamut-illustrations to be used in Teams checkout

PR Checklist

Testing Instructions

i think there's still a netlify issue so

  1. run storybook locally
  2. navigate to http://localhost:6006/?path=/docs/atoms-illustrations--docs
  3. validate new illustration StackedPagesVariant

alternatively you can go to the portal pr and follow those steps to see the illustration being used

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env (no ui to check though)
Portal Portal Link Portal Env

@nx-cloud
Copy link

nx-cloud bot commented Jan 29, 2025

View your CI Pipeline Execution ↗ for commit afa8dc4.


☁️ Nx Cloud last updated this comment at 2025-01-30 17:24:21 UTC

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/gamut@57.7.4-alpha.afa8dc.0
@codecademy/gamut-illustrations@0.52.0-alpha.afa8dc.0
@codecademy/gamut-kit@0.6.465-alpha.afa8dc.0

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://679bb592137c5dad006bd53e--gamut-preview.netlify.app

Deploy Logs

@linseyjayne linseyjayne marked this pull request as ready for review January 30, 2025 20:03
@linseyjayne linseyjayne requested a review from a team as a code owner January 30, 2025 20:03
@linseyjayne
Copy link
Contributor Author

I am not attached to this name at all 😅 if y'all have a suggestion I'm happy to change it, I didn't see other illustrations that were this similar

Copy link
Contributor

@saghdaey saghdaey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@linseyjayne linseyjayne added the Ship It :shipit: Automerge this PR when possible label Feb 3, 2025
@codecademydev codecademydev merged commit 39c8dbd into main Feb 3, 2025
32 of 33 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Feb 3, 2025
@codecademydev codecademydev deleted the lh-stacked-pages-variant-illus branch February 3, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants