Skip to content

feat(Illustration): Discount tag illustrations#3021

Merged
codecademydev merged 3 commits intomainfrom
hr-flow-1050-promo-illustrations
Feb 3, 2025
Merged

feat(Illustration): Discount tag illustrations#3021
codecademydev merged 3 commits intomainfrom
hr-flow-1050-promo-illustrations

Conversation

@zippyzow
Copy link
Contributor

@zippyzow zippyzow commented Jan 30, 2025 •
edited
Loading

Overview

Adds the following illustrations:

  • Tag50PercentOff
  • Tag30PercentOff
  • Tag25PercentOff

PR Checklist

Testing Instructions

Go to the Monolith PR and follow instructions there.

  • note: the 30% illustration will be used in FLOW-1044

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal PR N/A

@zippyzow zippyzow changed the title (feat)Discount tag illustrations feat(Illustration) Discount tag illustrations Jan 30, 2025
@nx-cloud
Copy link

nx-cloud bot commented Jan 30, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit fdf5b8e.

☁️ Nx Cloud last updated this comment at 2025-01-31 15:29:59 UTC

@codecademydev
Copy link
Collaborator

codecademydev commented Jan 31, 2025

📬Published Alpha Packages:

@codecademy/gamut@57.7.5-alpha.fdf5b8.0
@codecademy/gamut-illustrations@0.51.1-alpha.fdf5b8.0
@codecademy/gamut-kit@0.6.466-alpha.fdf5b8.0

@codecademydev
Copy link
Collaborator

codecademydev commented Jan 31, 2025

🚀 Styleguide deploy preview ready!

https://679cec448acf8d00ae38918b--gamut-preview.netlify.app

Deploy Logs

@zippyzow zippyzow changed the title feat(Illustration) Discount tag illustrations feat(Illustration): Discount tag illustrations Jan 31, 2025
@zippyzow zippyzow marked this pull request as ready for review January 31, 2025 18:18
@zippyzow zippyzow requested a review from a team as a code owner January 31, 2025 18:18
dreamwasp
dreamwasp approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, lgtm

@zippyzow zippyzow added the Ship It :shipit: Automerge this PR when possible label Feb 3, 2025
@codecademydev codecademydev merged commit 1065431 into main Feb 3, 2025
55 of 59 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Feb 3, 2025
@codecademydev codecademydev deleted the hr-flow-1050-promo-illustrations branch February 3, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcenglish jcenglish jcenglish approved these changes

@dreamwasp dreamwasp dreamwasp approved these changes

@jakemhiller jakemhiller Awaiting requested review from jakemhiller jakemhiller is a code owner automatically assigned from Codecademy/gamut

@BandanaKM BandanaKM Awaiting requested review from BandanaKM BandanaKM is a code owner automatically assigned from Codecademy/gamut

@xendke xendke Awaiting requested review from xendke

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zippyzow @codecademydev @jcenglish @dreamwasp