fix(ColorScale): updated notations for colors that have hyphen in their names #3061
Merged
codecademydev merged 4 commits intomainfrom Apr 3, 2025
Merged
fix(ColorScale): updated notations for colors that have hyphen in their names #3061codecademydev merged 4 commits intomainfrom
codecademydev merged 4 commits intomainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit f8aa646. ☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit f7e6dde.
☁️ Nx Cloud last updated this comment at |
Collaborator
📬Published Alpha Packages:@codecademy/styleguide@71.1.2-alpha.f8aa64.0 |
Collaborator
|
🚀 Styleguide deploy preview ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Colors that have hyphens in name should use bracket notation.
Currently such colors are rendered like:
theme.colors.for-examplebut should betheme.colors['for-example']PR Checklist
Testing Instructions
PR Links and Envs
N/A this PR affects Gamut only.