Conversation
|
View your CI Pipeline Execution ↗ for commit c650966. ☁️ Nx Cloud last updated this comment at |
LinKCoding
left a comment
LinKCoding
left a comment
There was a problem hiding this comment.
Left some thoughts on things I noticed, but will hold off on a bigger review until the walkthrough!
aresnik11
left a comment
aresnik11
left a comment
There was a problem hiding this comment.
Nice!! Mostly confirmed SB stories look amazing
| color: typeof tooltipBgColor | typeof popoverPrimaryBgColor; | ||
| }; | ||
|
|
||
| export const getBeakBackground = ({ |
There was a problem hiding this comment.
This seems more like setBeakBgAndRotation to me lol
| const isSml = alignment.includes('sml'); | ||
| const isAbove = alignment.includes('above'); | ||
| const isBelow = alignment.includes('below'); | ||
| const isRight = alignment.includes('right'); | ||
| const isXCentered = alignment.includes('-center'); | ||
| const isYCentered = alignment.startsWith('center-'); |
There was a problem hiding this comment.
NOT asking for a refactor!!
But food for thought, I think this can be simplified if you parsed out the alignment using .split("-") into the 1st string and the 2nd (and 3rd string, the 'sml', if present).
And then you can layer on stylings according the the positioning (and make adjustments for 'sml'). This might also involve changing how you're creating the styles tho 🤔
At the moment if statement feels like it's winds through all the different combos but it's a little hard to follow along.
📬Published Alpha Packages:@codecademy/gamut@64.1.0-alpha.c65096.0 |
|
🚀 Styleguide deploy preview ready! |
4 participants
Overview
Create
left-center+right-centeralignedToolTips+PopoversPR Checklist
Testing Instructions
Tipstories + see they are unchangedPR Links and Envs