Skip to content

docs: update screenreader text example to keep screenreader focus indicator on screen#3099

Merged
codecademydev merged 9 commits intomainfrom
kl-gm-1121-screenreader-doc-only
Jun 4, 2025
Merged

docs: update screenreader text example to keep screenreader focus indicator on screen#3099
codecademydev merged 9 commits intomainfrom
kl-gm-1121-screenreader-doc-only

Conversation

@LinKCoding
Copy link
Copy Markdown
Contributor

@LinKCoding LinKCoding commented Jun 3, 2025 •
edited
Loading

Overview

Updating the text screenreader story to keep the focus indicator of screenreaders on-screen.

PR Checklist

  • Related to JIRA ticket: GM-1121
  • I have run this code to verify it works

Testing Instructions

  1. Go to the preview and go to the text story
  2. Check that the screenreader text looks as expected (doesn't render on the page)
  3. Check it with VO, see that the text is read but the focus indicator is still on the screen (as compared with prod where the indicator is off the screen)
  4. Finish and do a celebratory dance

PR Links and Envs

N/A documentation change only

@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Jun 3, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit c050197.

☁️ Nx Cloud last updated this comment at 2025-06-04 15:47:24 UTC

@LinKCoding LinKCoding changed the title docs: update screenreader text example to keep screenreader focus indicator on screen fix: update screenreader text example to keep screenreader focus indicator on screen Jun 3, 2025
@LinKCoding LinKCoding changed the title fix: update screenreader text example to keep screenreader focus indicator on screen docs: update screenreader text example to keep screenreader focus indicator on screen Jun 3, 2025
@LinKCoding LinKCoding marked this pull request as ready for review June 3, 2025 19:48
@LinKCoding LinKCoding requested a review from a team as a code owner June 3, 2025 19:48
@LinKCoding LinKCoding requested review from aresnik11 and dreamwasp June 3, 2025 19:48
dreamwasp
dreamwasp approved these changes Jun 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this solution + appreciate all your research. you rock!!!!!

aresnik11
aresnik11 approved these changes Jun 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@aresnik11 aresnik11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@codecademydev
Copy link
Copy Markdown
Collaborator

codecademydev commented Jun 4, 2025

📬Published Alpha Packages:

@codecademy/styleguide@75.0.1-alpha.c05019.0

@codecademydev
Copy link
Copy Markdown
Collaborator

codecademydev commented Jun 4, 2025

🚀 Styleguide deploy preview ready!

https://68406a9e3c327d2bde460862--gamut-preview.netlify.app

Deploy Logs

@LinKCoding LinKCoding added the Ship It :shipit: Ready 2 ship label Jun 4, 2025
@codecademydev codecademydev merged commit 252d6e9 into main Jun 4, 2025
21 of 22 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Ready 2 ship label Jun 4, 2025
@codecademydev codecademydev deleted the kl-gm-1121-screenreader-doc-only branch June 4, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aresnik11 aresnik11 aresnik11 approved these changes

@dreamwasp dreamwasp dreamwasp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LinKCoding @codecademydev @aresnik11 @dreamwasp