docs: add dropdown to props table for icons, illustrations, patterns#3105
Merged
codecademydev merged 7 commits intomainfrom Jun 9, 2025
Merged
docs: add dropdown to props table for icons, illustrations, patterns#3105codecademydev merged 7 commits intomainfrom
codecademydev merged 7 commits intomainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit d1dd1de. ☁️ Nx Cloud last updated this comment at |
LinKCoding
reviewed
Jun 6, 2025
Contributor
LinKCoding
left a comment
There was a problem hiding this comment.
Love these changes!!
2 minor things:
- I really liked your additions for mini + regular where you included the usage, thoughts on adding similar code snippets to illustration and patterns?
- Even after deleting
sourceState="shown"the show code button is still there. Looks like you'll need to set it tosourceState="none"to remove the button altogether.
Contributor
Author
@LinKCoding i did add the snippet for patterns and illustrations, do you not see it? Re source state nice! I wasn’t trying to completely remove just make it not as obvious but that’s even better |
Contributor
😅 nope, just scrolled right past it lol |
…t into ajr-props-table-dropdown
Collaborator
📬Published Alpha Packages:@codecademy/styleguide@75.0.2-alpha.d1dd1d.0 |
Collaborator
|
🚀 Styleguide deploy preview ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Updates stories for icons, illustrations, patterns to show a dropdown for the icon, illustration, pattern in playground controls that dynamically updates the one shown in the playground
PR Checklist
Testing Instructions
Don't make me tap the sign.
PR Links and Envs
N/A