Skip to content

docs: add dropdown to props table for icons, illustrations, patterns#3105

Merged
codecademydev merged 7 commits intomainfrom
ajr-props-table-dropdown
Jun 9, 2025
Merged

docs: add dropdown to props table for icons, illustrations, patterns#3105
codecademydev merged 7 commits intomainfrom
ajr-props-table-dropdown

Conversation

@aresnik11
Copy link
Copy Markdown
Contributor

@aresnik11 aresnik11 commented Jun 6, 2025

Overview

Updates stories for icons, illustrations, patterns to show a dropdown for the icon, illustration, pattern in playground controls that dynamically updates the one shown in the playground

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GM-941
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Go to Patterns story
  2. See dropdown in playground controls
  3. Select an option
  4. See it update in the playground
  5. Go to Illustrations story
  6. Repeat 2-4
  7. Go to Mini icon story
  8. Repeat 2-4
  9. Go to Regular icon story
  10. Repeat 2-4
  11. Finish and do a celebratory dance

PR Links and Envs

N/A

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Jun 6, 2025

View your CI Pipeline Execution ↗ for commit d1dd1de.


☁️ Nx Cloud last updated this comment at 2025-06-09 13:23:48 UTC

@aresnik11 aresnik11 marked this pull request as ready for review June 6, 2025 18:05
@aresnik11 aresnik11 requested a review from a team as a code owner June 6, 2025 18:05
@aresnik11 aresnik11 requested a review from LinKCoding June 6, 2025 18:05
Copy link
Copy Markdown
Contributor

@LinKCoding LinKCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love these changes!!

2 minor things:

  1. I really liked your additions for mini + regular where you included the usage, thoughts on adding similar code snippets to illustration and patterns?
  2. Even after deleting sourceState="shown" the show code button is still there. Looks like you'll need to set it to sourceState="none" to remove the button altogether.

@aresnik11
Copy link
Copy Markdown
Contributor Author

Love these changes!!

2 minor things:

  1. I really liked your additions for mini + regular where you included the usage, thoughts on adding similar code snippets to illustration and patterns?
  2. Even after deleting sourceState="shown" the show code button is still there. Looks like you'll need to set it to sourceState="none" to remove the button altogether.

@LinKCoding i did add the snippet for patterns and illustrations, do you not see it? Re source state nice! I wasn’t trying to completely remove just make it not as obvious but that’s even better

@LinKCoding
Copy link
Copy Markdown
Contributor

@LinKCoding i did add the snippet for patterns and illustrations, do you not see it? Re source state nice! I wasn’t trying to completely remove just make it not as obvious but that’s even better

😅 nope, just scrolled right past it lol
but I see it!!

@codecademydev
Copy link
Copy Markdown
Collaborator

📬Published Alpha Packages:

@codecademy/styleguide@75.0.2-alpha.d1dd1d.0

@codecademydev
Copy link
Copy Markdown
Collaborator

🚀 Styleguide deploy preview ready!

https://6846e078e297a7884e7b05dc--gamut-preview.netlify.app

Deploy Logs

@aresnik11 aresnik11 requested a review from LinKCoding June 9, 2025 13:25
Copy link
Copy Markdown
Contributor

@LinKCoding LinKCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faaaantastic 🚀

@aresnik11 aresnik11 added the Ship It :shipit: Ready 2 ship label Jun 9, 2025
@codecademydev codecademydev merged commit f50536c into main Jun 9, 2025
22 of 23 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Ready 2 ship label Jun 9, 2025
@codecademydev codecademydev deleted the ajr-props-table-dropdown branch June 9, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants