fix(Card): remove extra transition from shadow variant#3110
Merged
codecademydev merged 2 commits intomainfrom Jul 1, 2025
Merged
fix(Card): remove extra transition from shadow variant#3110codecademydev merged 2 commits intomainfrom
codecademydev merged 2 commits intomainfrom
Conversation
…sing extra animation on firefox
|
View your CI Pipeline Execution ↗ for commit ac74fa6. ☁️ Nx Cloud last updated this comment at |
Collaborator
📬Published Alpha Packages:@codecademy/gamut@64.1.5-alpha.ac74fa.0 |
Collaborator
|
🚀 Styleguide deploy preview ready! |
LinKCoding
approved these changes
Jun 30, 2025
Contributor
LinKCoding
left a comment
There was a problem hiding this comment.
Thanks for catching and fixing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
in firefox our path cards have come alive with a heartbeat! ( i think due to an extra transition attribute )
https://github.com/user-attachments/assets/1da679e7-f526-49d1-a283-4dac7bd6e4b4
removes extra transition from shadow variant of card to fix firefox animation
PR Checklist
Testing Instructions
Don't make me tap the sign.
PR Links and Envs