Skip to content

fix(Card): remove extra transition from shadow variant#3110

Merged
codecademydev merged 2 commits intomainfrom
lh-dot-978-shadow-card-transition
Jul 1, 2025
Merged

fix(Card): remove extra transition from shadow variant#3110
codecademydev merged 2 commits intomainfrom
lh-dot-978-shadow-card-transition

Conversation

@linseyjayne
Copy link
Copy Markdown
Contributor

@linseyjayne linseyjayne commented Jun 12, 2025

Overview

in firefox our path cards have come alive with a heartbeat! ( i think due to an extra transition attribute )
https://github.com/user-attachments/assets/1da679e7-f526-49d1-a283-4dac7bd6e4b4

removes extra transition from shadow variant of card to fix firefox animation

PR Checklist

  • Related to designs: n/a
  • Related to JIRA ticket: DOT-978
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Go to isInteractive card story here
  2. Hover over the cards in firefox, make sure they animate as expected
  3. Do the same in chrome
  4. Do the same in dark mode
  5. Check it with VO
  6. You can also check in the portal app env here
  7. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Jun 12, 2025

View your CI Pipeline Execution ↗ for commit ac74fa6.


☁️ Nx Cloud last updated this comment at 2025-06-27 14:40:07 UTC

@codecademydev
Copy link
Copy Markdown
Collaborator

📬Published Alpha Packages:

@codecademy/gamut@64.1.5-alpha.ac74fa.0
@codecademy/gamut-kit@0.6.518-alpha.ac74fa.0

@codecademydev
Copy link
Copy Markdown
Collaborator

🚀 Styleguide deploy preview ready!

https://685ead6087e4de182e1bcc39--gamut-preview.netlify.app

Deploy Logs

@linseyjayne linseyjayne marked this pull request as ready for review June 30, 2025 19:01
@linseyjayne linseyjayne requested a review from a team as a code owner June 30, 2025 19:01
Copy link
Copy Markdown
Contributor

@LinKCoding LinKCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing!

@linseyjayne linseyjayne added the Ship It :shipit: Ready 2 ship label Jul 1, 2025
@codecademydev codecademydev merged commit 57c04a1 into main Jul 1, 2025
35 of 36 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Ready 2 ship label Jul 1, 2025
@codecademydev codecademydev deleted the lh-dot-978-shadow-card-transition branch July 1, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants