Skip to content

fix(List, DataList, DataTable): fix background colors + non-interactive table header spacing #3203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codecademydev merged 2 commits into from
Nov 7, 2025
Merged

fix(List, DataList, DataTable): fix background colors + non-interactive table header spacing #3203

codecademydev merged 2 commits into from
Nov 7, 2025

Conversation

@dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Nov 5, 2025 •
edited
Loading

Overview

Fixes background colors + non-interactive table header spacing

PR Checklist

  • Related to designs: pre-existing designs
  • Related to JIRA ticket: [GTM-219]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

** There are aLOT of ugly red backgrounds everywhere! i will remove them from the examples before shipping, it just makes it easier to test the contrast**

  1. Go to List story
  2. See that all List variants have background colors except table + plain
  3. See that DataTable has a background based on background-current
  4. See that DataList has a background
  5. See that non-interactive column headers are now correctly aligned with the other headers

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@nx-cloud
Copy link

nx-cloud bot commented Nov 5, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 89854c4

☁️ Nx Cloud last updated this comment at 2025-11-07 18:35:42 UTC

@dreamwasp dreamwasp marked this pull request as ready for review November 5, 2025 19:48
@dreamwasp dreamwasp requested a review from a team as a code owner November 5, 2025 19:48
katiezutter
katiezutter approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@katiezutter katiezutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great on my end!!

aresnik11
aresnik11 approved these changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@aresnik11 aresnik11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecademydev
Copy link
Collaborator

codecademydev commented Nov 7, 2025

📬 Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

🚀 Styleguide deploy preview ready!

Preview URL: https://690e3cbd40182d07a8091660--gamut-preview.netlify.app
Deploy Logs: https://app.netlify.com/projects/gamut-preview/deploys/690e3cbd40182d07a8091660

@dreamwasp dreamwasp added the Ship It :shipit: Automerge this PR when possible label Nov 7, 2025
@codecademydev codecademydev merged commit ceb1162 into main Nov 7, 2025
17 of 18 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Nov 7, 2025
@codecademydev codecademydev deleted the cass-gmt-219-BG branch November 7, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aresnik11 aresnik11 aresnik11 approved these changes

@katiezutter katiezutter katiezutter approved these changes

@jakemhiller jakemhiller Awaiting requested review from jakemhiller jakemhiller is a code owner automatically assigned from Codecademy/gamut

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dreamwasp @codecademydev @aresnik11 @katiezutter