feat: improved feeds validation UX #1090
Conversation
RaduCristianPopescu
added
the
pr-checklist-skip
There was a problem hiding this comment.
Pull Request Overview
This pull request implements improved UX for feed validation by replacing the external validation link with an integrated AJAX-based validation system. Users can now validate RSS feeds directly within the interface and receive immediate feedback about feed status.
Key changes include:
- Replacement of external W3C validator with internal AJAX validation
- Real-time validation with visual feedback (success/error/warning states)
- Automatic separation of valid and invalid URLs after validation
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| includes/views/js/import-metabox-edit.js | Complete rewrite of validation logic with async AJAX calls and improved UX |
| includes/views/import-metabox-edit.php | Updated HTML structure to support new validation interface |
| includes/views/css/import-metabox-edit.css | Added styling for validation messages and status indicators |
| includes/feedzy-rss-feeds.php | Registered new AJAX action for feed validation |
| includes/admin/feedzy-rss-feeds-import.php | Added AJAX URL to JavaScript configuration |
| includes/admin/feedzy-rss-feeds-admin.php | Implemented server-side feed validation method |
Comments suppressed due to low confidence (2)
includes/admin/feedzy-rss-feeds-admin.php:429
- Missing return statement: The security check continues execution after wp_send_json_error() instead of returning, which could lead to processing invalid requests.
</div>
includes/admin/feedzy-rss-feeds-admin.php:515
- Incorrect string concatenation: The title and sprintf result are concatenated without proper spacing, which will result in malformed messages like 'Feed Title5 items found'.
position: relative;
|
Plugin build for 565de17 is ready 🛎️!
Note You can preview the changes in the Playground |
| $message.append('<button type="button" class="button button-primary">✕</button>'); | ||
| $message.find('button').on('click', function(e) { | ||
| e.preventDefault(); | ||
| $(this).parent().fadeOut(300, () => $(this).remove()); | ||
| }); |
There was a problem hiding this comment.
Use the same pattern as the $message with $closeButton
pirate-bot
added
the
pr-checklist-complete
|
@Soare-Robert-Daniel this was supposed to work for feedzy loop & feedzy classic block as well and feed groups validate actions. |
Those will be addressed in a separate PR. This one adds the initial workflow for individual feeds; it looks okay, so we can proceed with the rest. |
RaduCristianPopescu
force-pushed
the
fix/feed-validater
branch
2 times, most recently
from
1e63c91 to
854b7bf
Compare
Soare-Robert-Daniel
force-pushed
the
fix/feed-validater
branch
from
854b7bf to
2204d67
Compare
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Soare-Robert-Daniel
force-pushed
the
fix/feed-validater
branch
from
2204d67 to
565de17
Compare
Summary
Redesign the Edit Import Sources Configuration, Feedzy Classic and Loop Block. Now the user only needs 1 button to validate the input.
Will affect visual aspect of the product
YES
Screenshots
EditImport.3.mp4
Recording.mp4
Test instructions
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/870