-
Notifications
You must be signed in to change notification settings - Fork 27
fix: add disabled state for PRO actions in ActionModal #1097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
fix: add disabled state for PRO actions in ActionModal #1097
Conversation
Plugin build for bbe1256 is ready 🛎️!
Note You can preview the changes in the Playground |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses the ability for users to select PRO features by adding a disabled state for PRO actions in the ActionModal component. The changes prevent non-PRO users from clicking on premium features while maintaining clear visual indication of what's available in PRO plans.
Key changes include:
- Converted clickable PRO action items to non-clickable disabled states with visual styling
- Wrapped action buttons in proper HTML button elements for better accessibility
- Added CSS styling for disabled PRO items and action buttons
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
js/ActionPopup/index.js | Refactored action list items to use buttons and added disabled states for PRO features when user lacks appropriate plan |
css/settings.css | Added styling for disabled PRO items and action buttons |
css/settings.css
Outdated
|
||
button.feedzy-action-button { | ||
padding: 13px 0px; | ||
height: 0px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting height to 0px while using padding creates an unusual box model that may cause layout issues. Consider using a more conventional approach like setting a specific height or using line-height for vertical spacing.
height: 0px; |
Copilot uses AI. Check for mistakes.
5d9ea87
to
e388725
Compare
e388725
to
d271b91
Compare
d271b91
to
bbe1256
Compare
@Soare-Robert-Daniel, The Pro actions are not clickable, but they don’t appear greyed out on my end. ![]() |
Summary
User can't select the pro feats no more.
Will affect visual aspect of the product
NO
Screenshots
Test instructions
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/860