Skip to content

fix: add disabled state for PRO actions in ActionModal #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

RaduCristianPopescu
Copy link
Contributor

Summary

User can't select the pro feats no more.

Will affect visual aspect of the product

NO

Screenshots

CleanShot 2025-07-21 at 12 08 07@2x

Test instructions

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/860

@RaduCristianPopescu RaduCristianPopescu self-assigned this Jul 21, 2025
@RaduCristianPopescu RaduCristianPopescu added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jul 21, 2025
Copilot

This comment was marked as outdated.

@RaduCristianPopescu RaduCristianPopescu marked this pull request as ready for review July 21, 2025 09:34
@pirate-bot
Copy link
Contributor

pirate-bot commented Jul 21, 2025

Plugin build for bbe1256 is ready 🛎️!

Note

You can preview the changes in the Playground

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Jul 21, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses the ability for users to select PRO features by adding a disabled state for PRO actions in the ActionModal component. The changes prevent non-PRO users from clicking on premium features while maintaining clear visual indication of what's available in PRO plans.

Key changes include:

  • Converted clickable PRO action items to non-clickable disabled states with visual styling
  • Wrapped action buttons in proper HTML button elements for better accessibility
  • Added CSS styling for disabled PRO items and action buttons

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
js/ActionPopup/index.js Refactored action list items to use buttons and added disabled states for PRO features when user lacks appropriate plan
css/settings.css Added styling for disabled PRO items and action buttons

css/settings.css Outdated

button.feedzy-action-button {
padding: 13px 0px;
height: 0px;
Copy link
Preview

Copilot AI Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting height to 0px while using padding creates an unusual box model that may cause layout issues. Consider using a more conventional approach like setting a specific height or using line-height for vertical spacing.

Suggested change
height: 0px;

Copilot uses AI. Check for mistakes.

@Soare-Robert-Daniel Soare-Robert-Daniel force-pushed the fix/actions-dropdown-inter-upsell branch from 5d9ea87 to e388725 Compare July 29, 2025 14:03
@RaduCristianPopescu RaduCristianPopescu force-pushed the fix/actions-dropdown-inter-upsell branch from e388725 to d271b91 Compare August 8, 2025 09:49
@Soare-Robert-Daniel Soare-Robert-Daniel force-pushed the fix/actions-dropdown-inter-upsell branch from d271b91 to bbe1256 Compare August 11, 2025 08:49
@poonam279
Copy link

@Soare-Robert-Daniel, The Pro actions are not clickable, but they don’t appear greyed out on my end.

Screenshot 2025-08-11 at 5 40 58 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants