feat: added helper notice for headers and proxy #1128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaduCristianPopescu
added
the
pr-checklist-skip
pirate-bot
added
pr-checklist-complete
There was a problem hiding this comment.
Pull Request Overview
This PR adds helpful contextual information to the headers and proxy configuration sections in the Feedzy RSS Feeds plugin settings. The changes provide users with clear guidance on when and why to use these advanced features.
- Added informational notices with explanations for headers and proxy configurations
- Included "Learn more" links to external documentation
- Conditionally hid the generic "Need help?" button when viewing headers or proxy tabs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| includes/layouts/settings.php | Added helper notices with contextual information for headers and proxy sections, and conditionally hide generic help button |
| css/settings.css | Added styling for the new helper notice components with blue theme styling |
|
Plugin build for 33535e5 is ready 🛎️!
Note You can preview the changes in the Playground |
RaduCristianPopescu
force-pushed
the
feat/helper_proxy
branch
from
cd56402 to
e62dfe3
Compare
Closed
6 tasks
css/settings.css
Outdated
| @@ -2573,4 +2573,18 @@ li.draggable-item .components-panel__body-toggle.components-button{ | |||
| .support-box-list > ul{ | |||
| grid-template-columns: repeat(2, 1fr); | |||
| } | |||
| } | |||
|
|
|||
| .feedzy_helper_notice { | |||
There was a problem hiding this comment.
Use feedzy-helper-notice
Soare-Robert-Daniel
force-pushed
the
feat/helper_proxy
branch
from
12b1abd to
33535e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added helper information on proxy & user-agent.
Will affect visual aspect of the product
YES
Screenshots
Headers
Proxy
Other
Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/871