Skip to content

feat: change the integration upsell label based on the license plan #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2025

Conversation

girishpanchal30
Copy link
Contributor

Summary

Show the plan-based notice to the integrations

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/851

@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label Aug 8, 2025
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Aug 8, 2025
@pirate-bot
Copy link
Contributor

pirate-bot commented Aug 8, 2025

Plugin build for ce1cc27 is ready 🛎️!

Note

You can preview the changes in the Playground

@@ -1,10 +1,14 @@
<?php
$plan = apply_filters( 'product_feedzy_license_plan', 0 );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that $plan is not used. Did you forget to remove it after you started using the filter apply_filters( 'feedzy_is_license_of_type', false, 'business' )?

@@ -1,10 +1,14 @@
<?php
$plan = apply_filters( 'product_feedzy_license_plan', 0 );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,10 +1,14 @@
<?php
$plan = apply_filters( 'product_feedzy_license_plan', 0 );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,16 +1,18 @@
<?php
$plan = apply_filters( 'product_feedzy_license_plan', 0 );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,10 +1,14 @@
<?php
$plan = apply_filters( 'product_feedzy_license_plan', 0 );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some mentions about $plan

@Soare-Robert-Daniel Soare-Robert-Daniel changed the title show plan-based notice for pro features feat: change the integration upsell label based on the license plan Aug 12, 2025
@Soare-Robert-Daniel Soare-Robert-Daniel merged commit d26b431 into development Aug 12, 2025
11 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the bugfix/pro/851 branch August 12, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants