Feat/improved scaling

[selul]

https://github.com/Codeinwp/optimole-service/issues/1524

[pirate-bot]

Plugin build for c865ec8 is ready 🛎️!

• Download build
• Download dev

[ineagu]

• I couldn't get the caching clearance to work as expected on wpshout @selul . I am not sure is because of Kinsta cache, this works if I clear wp-rocket cache, which I think trigger Kinsta clearing as well.

• The solution that we are using to fix the sizes for the images that were previously lazy-loaded doesn't seem to work and I am not sure if we can find a solution :

This image is originally loaded like this on desktop :

After profiling, is being loaded like this : 




It got the width height from the mobile profiling : .

[selul]

@ineagu please share the page.

[ineagu]

@ineagu please share the page.

https://wpshout.com

[ineagu]

Another test I did :

https://testing-scaling.vertisite.cloud/elementor-101/

• we correctly identify LCP on both mobile/desktop ( it is a bg image ), same as reported by Google pagespeed

However we are lazy loading that part after the profiler runs.

At the same time I saw in this case and others that it appears that CORE functionality for LCP run along ours, and in this case they set the wrong LCP, is not a big deal, but I was wondering if this might be the reason we don't properly set the bg image we identified as LCP (preload + fetch priority high )

2. the detection script detect 09439917-listing-lg.png image as loading with the correct size with if in the network tab we see the wrong size was requested. I think it's happening because the srcset is correct, but still the image is not loading correctly.

[selul]

@ineagu fixed the wpshouts things, fyi on the caching issue kinsta did had compatibility with wprocket on clear cache so they work in sync but only global and not per url as we need for profiler, so I had to add dedicated compatibility with per url.

will look into the. lcp ones.

[ineagu]

@ineagu fixed the wpshouts things, fyi on the caching issue kinsta did had compatibility with wprocket on clear cache so they work in sync but only global and not per url as we need for profiler, so I had to add dedicated compatibility with per url.

will look into the. lcp ones.

great, we don't need to cover more now.

Found another use-case with our dear theme:

https://lighter-puma-019eef.vertisite.cloud/

The LCP image is a background image in css, which Optimole is not replacing. However our profiler is correcly identifying it as LCP, shouldn't we be able to preload it in this case, even if is not a optimole url? Thoughts?

Not sure if replacing is also fixable, this is set using otter section as a background image, would be helpful if Otter is compatible with Optimole.

[selul]

However our profiler is correcly identifying it as LCP, shouldn't we be able to preload it in this case, even if is not a optimole url

No, it only considers Optimole URLs. Adding it will open up different risks and complexities which we need to account.

[selul]

Regarding the LCP issues here those are happening because you have not enabled viewport based lazyloading.

[ineagu]

Regarding the LCP issues here those are happening because you have not enabled viewport based lazyloading.

even if it enabled the behavour is the same.

The issue I discovered is that skip lazy 2 takes precedence, it works as expected only after I disable the skip lazy 2, which should have been a fallback only. ( Reported this to Robert)

[selul]

@ineagu from my testing is not the same, I was able to view this correctly on your page, the bg image is preloaded.

[ineagu]

With both enabled correct?

[ineagu]

@selul I would suggest we merge here and set viewport based as enabled by default for the new users. We can monitor more real use-cases after release, but since we are always loading the profiler for our other improvements, it would make sense to use it for this as well.

I would do some more checks on the sizes part .

[selul]

With both enabled correct?

yes

[pirate-bot]

🎉 This PR is included in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀