Skip to content

Fixed php deprecation warning #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abaicus merged 2 commits into from
May 21, 2025
Merged

Fixed php deprecation warning #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
460f562
fix: php deprecation warning
girishpanchal30 May 19, 2025
678c786
update cache version for php test
girishpanchal30 May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
run: |
echo "::set-output name=dir::$(composer config cache-files-dir)"
- name: Setup Composer cache
uses: actions/cache@v1
uses: actions/cache@v4
with:
path: ${{ steps.composer-cache.outputs.dir }}
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
Expand Down
4 changes: 2 additions & 2 deletions includes/WP_Cli.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ public function import( $args, $assoc_args ) {
$sites = $this->get_all_sites();
$site_slug = $args[0];
if ( ! array_key_exists( $site_slug, $sites ) ) {
\WP_CLI::warning( "No site to import with the slug ${site_slug}." );
\WP_CLI::warning( "No site to import with the slug {$site_slug}." );

return;
}
Expand Down Expand Up @@ -257,7 +257,7 @@ function ( &$item ) {
*/
private function import_xml_file( $path, $json, $editor ) {
if ( ! file_exists( $path ) || ! is_readable( $path ) ) {
\WP_CLI::warning( "Cannot import XML file. Either the file is not readable or it does not exist (${path})" );
\WP_CLI::warning( "Cannot import XML file. Either the file is not readable or it does not exist ({$path})" );
}
$this->content_importer->import_file( $path, $json, $editor );
$this->content_importer->maybe_bust_elementor_cache();
Expand Down
Loading