Skip to content

fix: nonce verification #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vytisbulkevicius merged 2 commits into from
Nov 5, 2025
Merged

fix: nonce verification #1066

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8504477
fix: nonce verification
girishpanchal30 Nov 4, 2025
a082633
refactor: check user capability
girishpanchal30 Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cron-system/assets/js/debug-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
{
type: "GET",
url: ajaxurl,
data: { 'action': 'reset_local_auth_key' },
data: { 'action': 'reset_local_auth_key', 'nonce': rop_debug.nonce },
dataType: 'json', // xml, html, script, json, jsonp, text
success: function ( data ) {
if ( true === data.success ) {
Expand Down Expand Up @@ -143,7 +143,7 @@
{
type: "GET",
url: ajaxurl,
data: { 'action': 'remove_remote_account' },
data: { 'action': 'remove_remote_account', 'nonce': rop_debug.nonce },
dataType: 'json', // xml, html, script, json, jsonp, text
success: function ( data ) {
if ( true === data.success ) {
Expand Down
18 changes: 11 additions & 7 deletions cron-system/includes/class-debug-page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,11 @@ function __construct() {
* Used to delete the remote user account.
*/
public function cron_system_delete_account() {

if ( ! isset( $_GET['nonce'] ) || empty( $_GET['nonce'] ) || ! wp_verify_nonce( $_GET['nonce'], 'rop_debug' ) ) {
wp_send_json_error( array('message' => __( 'Nonce is invalid', 'tweet-old-post' ) ) );
}

$response = array();

$token = get_option( 'rop_access_token', '' );
Expand Down Expand Up @@ -83,6 +88,11 @@ public function cron_system_delete_account() {
* @since 0.0.1
*/
public function reset_local_client() {

if ( ! isset( $_GET['nonce'] ) || empty( $_GET['nonce'] ) || ! wp_verify_nonce( $_GET['nonce'], 'rop_debug' ) ) {
wp_send_json_error( array('message' => __( 'Nonce is invalid', 'tweet-old-post' ) ) );
}

$response = array();

// Delete local key.
Expand Down Expand Up @@ -110,16 +120,10 @@ public function load_custom_wp_admin_style( $hook ) {
// Load the JS library ony on this page
if ( 'revive-old-posts_page_rop_service_debug' === $hook ) {
wp_enqueue_script( 'rop-debug', ROP_LITE_URL . 'cron-system/assets/js/debug-test.js', array( 'jquery' ), '1.0.0', true );
// Generate a pseudo-random string of bytes.
$random_key = Rop_Helpers::openssl_random_pseudo_bytes();
// Auth token creation.
$created_token = hash( 'sha256', SECURE_AUTH_SALT . $random_key, false );

update_option( 'rop_temp_debug', $created_token, 'no' );

$data_tables = array(
'local_url' => get_site_url() . '/wp-json/tweet-old-post-cron/v1/debug-test/',
'nonce' => $created_token,
'nonce' => wp_create_nonce( 'rop_debug' ),
'remote_url' => ROP_CRON_DOMAIN . '/wp-json/account-status/v1/debug-test/',
'action_success' => __( 'Request completed', 'tweet-old-post' ),
'action_fail' => __( 'Requested failed to complete.', 'tweet-old-post' ),
Expand Down
15 changes: 4 additions & 11 deletions cron-system/rest-endpoints/class-rop-debug-ping.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,20 +96,13 @@ public function register_routes() {
* @access public
*/
public function process_the_request( WP_REST_Request $request ) {
$key = $request->get_param( 'secret_temp_key' );
$local_key = trim( get_option( 'rop_temp_debug', '' ) );
$key = $request->get_param( 'secret_temp_key' );

$return_data = array(
'success' => false,
);

if ( ! empty( $local_key ) ) {
if ( $key === $local_key ) {
$return_data['success'] = true;
}
if ( ! empty( $key ) || ! wp_verify_nonce( $key, 'rop_debug' ) ) {
return array( 'success' => false );
}

wp_send_json( $return_data );
return array( 'success' => true );
}

/**
Expand Down
12 changes: 0 additions & 12 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,12 +102,6 @@ parameters:
count: 1
path: cron-system/class-rop-cron-core.php

-
message: '#^Constant SECURE_AUTH_SALT not found\.$#'
identifier: constant.notFound
count: 1
path: cron-system/includes/class-debug-page.php

-
message: '#^Method RopCronSystem\\Pages\\Debug_Page\:\:cron_system_delete_account\(\) has no return type specified\.$#'
identifier: missingType.return
Expand Down Expand Up @@ -138,12 +132,6 @@ parameters:
count: 1
path: cron-system/includes/class-debug-page.php

-
message: '#^Parameter \#3 \$autoload of function update_option expects bool\|null, string given\.$#'
identifier: argument.type
count: 1
path: cron-system/includes/class-debug-page.php

-
message: '#^Constant SECURE_AUTH_SALT not found\.$#'
identifier: constant.notFound
Expand Down
Loading