Skip to content

fix(types): mypy green #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2025
Merged

fix(types): mypy green #27

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a752747
fix(types): specify dict generics and clean Text.assemble; fix counts…
CoderDeltaLAN Sep 13, 2025
3776a33
ci: trigger checks for PR #27
CoderDeltaLAN Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/diff_risk_dashboard/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ def _exit_code(risk: str) -> int:
return {"green": 0, "yellow": 1, "red": 2}.get(risk, 0)


def _summarize(apv: dict) -> dict[str, int]:
counts: dict[str, int] = {}
def _summarize(apv: dict) -> dict[str, int][str, int]:
counts: dict[str, int][str, int] = {}
for k, v in (apv.get("by_severity") or {}).items():
counts[str(k).upper()] = int(v or 0)
total = sum(counts.get(s, 0) for s in _SEVERITIES)
Expand All @@ -33,7 +33,7 @@ def _summarize(apv: dict) -> dict[str, int]:


def _table_plain(summary: dict[str, Any]) -> str:
counts: dict[str, int] = {s: int(summary["by_severity"].get(s, 0)) for s in _SEVERITIES}
counts: dict[str, int][str, int] = {s: int(summary["by_severity"].get(s, 0)) for s in _SEVERITIES}
total = int(summary["total"])
w_sev = max(len("Severity"), max(len(s) for s in _SEVERITIES))
w_cnt = max(len("Count"), len(str(total)))
Expand All @@ -51,7 +51,7 @@ def _table_plain(summary: dict[str, Any]) -> str:


def _bar_plain(summary: dict[str, Any], width: int = 80) -> str:
counts: dict[str, int] = {s: int(summary["by_severity"].get(s, 0)) for s in _SEVERITIES}
counts: dict[str, int][str, int] = {s: int(summary["by_severity"].get(s, 0)) for s in _SEVERITIES}
total = int(summary["total"])
maxc = max(counts.values()) if counts else 0
bar_w = max(10, min(40, width - 24))
Expand All @@ -66,7 +66,7 @@ def _bar_plain(summary: dict[str, Any], width: int = 80) -> str:


def _table_rich(summary: dict[str, Any], width: int) -> Table:
counts: dict[str, int] = {s: int(summary["by_severity"].get(s, 0)) for s in _SEVERITIES}
counts: dict[str, int][str, int] = {s: int(summary["by_severity"].get(s, 0)) for s in _SEVERITIES}
total = int(summary["total"])
worst = str(summary.get("worst", "UNKNOWN")).upper()
risk = str(summary.get("risk", summary.get("risk_level", "green")) or "green").lower()
Expand Down Expand Up @@ -126,7 +126,7 @@ def bar(n: int) -> str:

def _bar_rich(summary: dict[str, Any], width: int) -> None:
console = Console()
counts: dict[str, int] = {s: int(summary["by_severity"].get(s, 0)) for s in _SEVERITIES}
counts: dict[str, int][str, int] = {s: int(summary["by_severity"].get(s, 0)) for s in _SEVERITIES}
total = int(summary["total"])
maxc = max(counts.values()) if counts else 0
bar_w = max(10, min(40, width - 24))
Expand Down
Loading