MJ - Day2 #3
Open
MJ - Day2 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ami777
reviewed
Jan 31, 2018
| let sum = JSON.parse(data).reduce((x, y) => x + y); | ||
|
|
||
| fs.writeFile('./data/zadanie01/sum.txt', sum, err => { | ||
| let msg = err ? 'Błąd zapisu pliku' : 'Plik poprawnie zapisany'; |
Contributor
There was a problem hiding this comment.
Nice! Dodatkowo, można było użyć const.
|
|
||
| files.forEach(file => { | ||
| console.log(`Nazwa pliku: ${file}`); | ||
| let data = fs.readFileSync(`${path}${file}`); |
Contributor
There was a problem hiding this comment.
Staramy się zawsze używać funkcji asynchronicznych - dlatego tylko takie poznaliśmy. Dzięki temu kiedy Node.js "nudzi się" odczytem pliku - mogą się dziać inne rzeczy.
Author
There was a problem hiding this comment.
Tak racja. Chciałem tym uzyskać odczyt pliku pod nazwą pliku bez rejestrowania eventu :)
Contributor
There was a problem hiding this comment.
Jasna sprawa :) Wygląda "prościej", ale właśnie nie korzysta z tej przewagi Node.
Natomiast taka ciekawostka, że używając Promise + async/await da się pisać kod który wygląda jak synchroniczny, a jest asynchroniczny ^^
| fs.readFile(path, 'utf-8', (err, data) => { | ||
| if (err) return console.log('Błąd odczytu pliku'); | ||
|
|
||
| let newData = [...data].map((elem, i) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.