Skip to content

Commit 0fcd2f5

Browse files
Backport PR jupyterlab#11391: Improve documentation on galata setup (jupyterlab#11400)
Co-authored-by: Frédéric Collonval <[email protected]>
1 parent 9a45a3e commit 0fcd2f5

File tree

4 files changed

+12
-4
lines changed

4 files changed

+12
-4
lines changed

MANIFEST.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ recursive-exclude jupyterlab *.js.map
3434

3535
# Galata
3636
include galata/README.md
37-
include galata/jupyter_server_config.py
37+
include galata/jupyter_server_test_config.py
3838
include galata/*.js
3939
recursive-include galata/media *.*
4040
graft galata/src

galata/README.md

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jlpm playwright install
2626

2727
Create a Playwright configuration file `playwright.config.js` containing:
2828

29-
```
29+
```js
3030
module.exports = require('@jupyterlab/galata/lib/playwright-config');
3131
```
3232

@@ -66,8 +66,8 @@ Create `jupyter_server_test_config.py` with the following content.
6666
from tempfile import mkdtemp
6767

6868
c.ServerApp.port = 8888
69+
c.ServerApp.port_retries = 0
6970
c.ServerApp.open_browser = False
70-
c.LabApp.dev_mode = True
7171

7272
c.ServerApp.root_dir = mkdtemp(prefix='galata-test-')
7373
c.ServerApp.token = ""
@@ -137,6 +137,13 @@ PWDEBUG=1 jlpm playwright test
137137

138138
Here are the new test fixture introduced by Galata on top of [Playwright fixtures](https://playwright.dev/docs/api/class-fixtures).
139139

140+
### baseURL
141+
142+
- type: < string >
143+
144+
Application base URL without `/lab`. It defaults to environment variable `TARGET_URL` or `http://localhost:8888` if nothing
145+
is defined.
146+
140147
### appPath
141148

142149
- type: < string >

galata/jupyter_server_config.py renamed to galata/jupyter_server_test_config.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
c.ServerApp.ip = "0.0.0.0"
77

88
c.ServerApp.port = 8888
9+
c.ServerApp.port_retries = 0
910
c.ServerApp.open_browser = False
1011
c.LabApp.dev_mode = True
1112

galata/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
"build:galata": "tsc -b",
3535
"build:inpage": "webpack --mode=production",
3636
"clean": "rimraf lib tsconfig.tsbuildinfo",
37-
"start": "jupyter lab --config ./jupyter_server_config.py",
37+
"start": "jupyter lab --config ./jupyter_server_test_config.py",
3838
"start:detached": "(jlpm run start&)",
3939
"test": "playwright test",
4040
"test:benchmark": "jlpm run test -c playwright-benchmark.config.js",

0 commit comments

Comments
 (0)