Skip to content

Fix type export #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CGNonofr merged 2 commits into from
Feb 4, 2025
Merged

Fix type export #570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84a9d4e
fix: missing exported type
Feb 3, 2025
f3d7896
fix: missing typeVersions
Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions rollup/tools/configuredSubpackagePlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,6 +454,11 @@ export function configuredSubpackagePlugin(): rollup.Plugin {
default: './*.js',
types: './*.d.ts'
}
},
typesVersions: {
'*': {
'vscode/*': ['./vscode/src/*.d.ts']
}
}
}
} else {
Expand Down Expand Up @@ -482,6 +487,11 @@ export function configuredSubpackagePlugin(): rollup.Plugin {
default: './*.js',
types: './*.d.ts'
}
},
typesVersions: {
'*': {
'vscode/*': ['./vscode/src/*.d.ts']
}
}
}
}
Expand Down
6 changes: 5 additions & 1 deletion src/services.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ import {
} from 'vs/platform/instantiation/common/instantiation'
import type { IAction } from 'vs/base/common/actions'
import { DisposableStore, type IDisposable } from 'vs/base/common/lifecycle'
import type { IWorkbenchConstructionOptions } from 'vs/workbench/browser/web.api'
import type {
IWorkbenchConstructionOptions,
IWorkspaceProvider
} from 'vs/workbench/browser/web.api'
import type { IProductConfiguration } from 'vs/base/common/product'
import {
type ILazyWorkbenchContributionInstantiation,
Expand Down Expand Up @@ -347,6 +350,7 @@ export type {
ITextModelContentProvider,
IColorTheme,
IWorkbenchConstructionOptions,
IWorkspaceProvider,
IEditorOverrideServices,
WorkbenchContributionInstantiation,
ILazyWorkbenchContributionInstantiation,
Expand Down