-
Notifications
You must be signed in to change notification settings - Fork 56
Allow configuring extension host worker options #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuring extension host worker options #580
Conversation
kaisalmen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then let's bring the options back. LGTM
Don't you have any issue regarding it on your side? |
|
@CGNonofr we need to adapt. |
|
The v14 PR in mlc is still a Draft 🙂 |
It's not a regression of the v14 though, it's been multiple versions |
|
Yes, I understand. It is fixed to a module as well: |
webpack removes the |
|
Fancy piece of software! 😉 Yes, that must be made configurable there ⬆️ |
|
🎉 This PR is included in version 14.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
It was removed during a VSCode refactor removing non-ESM code. But we do need to support non-esm workers for webpack