Skip to content

Conversation

@CGNonofr
Copy link
Contributor

It was removed during a VSCode refactor removing non-ESM code. But we do need to support non-esm workers for webpack

@CGNonofr CGNonofr requested a review from kaisalmen February 11, 2025 16:03
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then let's bring the options back. LGTM

@CGNonofr
Copy link
Contributor Author

Then let's bring the options back. LGTM

Don't you have any issue regarding it on your side?

@CGNonofr CGNonofr merged commit 54ac8d7 into main Feb 11, 2025
2 checks passed
@CGNonofr CGNonofr deleted the allow-configuring-extension-host-worker-options branch February 11, 2025 16:30
@kaisalmen
Copy link
Collaborator

@CGNonofr we need to adapt.

@kaisalmen
Copy link
Collaborator

The v14 PR in mlc is still a Draft 🙂

@CGNonofr
Copy link
Contributor Author

The v14 PR in mlc is still a Draft 🙂

It's not a regression of the v14 though, it's been multiple versions

@kaisalmen
Copy link
Collaborator

@CGNonofr
Copy link
Contributor Author

Yes, I understand. It is fixed to a module as well: https://github.com/TypeFox/monaco-languageclient/blob/main/packages/client/src/vscode/services.ts#L163-L175

webpack removes the type: 'module though

@kaisalmen
Copy link
Collaborator

Fancy piece of software! 😉 Yes, that must be made configurable there ⬆️

@github-actions
Copy link

🎉 This PR is included in version 14.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants