Fix extension host worker when used with a cdn #581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@kaisalmen I'm trying to update the lib in our apps which all use the last version of webpack, and I'm surprised to encounter so many issues that nobody had before 🤔 |
Collaborator
Webpack changed to better or worse or nobody looked closely enough. I don't use webpack if I don't have to, so the checks in mlc are limited to basic bundling checks. |
|
🎉 This PR is included in version 14.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the extension host iframe is hosted on another domain, it refuses messages from the main thread because the domain does not match. VSCode handle this by adding a
parentOriginparameter but in our case it wasn't usedAlso, force set the domain of the extension host worker, it was the case before a previous refactor and is a regression, forcing us to set the webpack
publicPathfor it to work, or provide aiframeAlternateDomainby hands