Skip to content

Fix export order #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CGNonofr merged 2 commits into from
Mar 3, 2025
Merged

Fix export order #591

CGNonofr merged 2 commits into from
Mar 3, 2025

Conversation

@CGNonofr
Copy link
Contributor

@CGNonofr CGNonofr commented Feb 27, 2025

fix #590

@CGNonofr CGNonofr requested a review from kaisalmen February 27, 2025 14:19
kaisalmen
kaisalmen reviewed Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@kaisalmen kaisalmen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the typo the actual problem and not the order?

@CGNonofr
Copy link
Contributor Author

CGNonofr commented Mar 3, 2025 •
edited
Loading

Is the typo the actual problem and not the order?

The error message is pretty clear though

In my experience, the type typesVersions field is used and the exports.types is pretty much ignored 🤔 , which explain why we didn't notice the typo

kaisalmen
kaisalmen approved these changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaisalmen
Copy link
Collaborator

kaisalmen commented Mar 3, 2025

The error message is pretty clear though

Ok

In my experience, the type typesVersions field is used and the exports.types is pretty much ignored 🤔 , which explain why we didn't notice the typo

Yes, that makes sense.

@CGNonofr CGNonofr merged commit cddbe1c into main Mar 3, 2025
2 checks passed
@CGNonofr CGNonofr deleted the fix-export-order branch March 3, 2025 14:09
@github-actions
Copy link

github-actions bot commented Mar 3, 2025

🎉 This PR is included in version 14.0.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaisalmen kaisalmen kaisalmen approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect exports Order in package.json Causes Webpack Build Error

3 participants

@CGNonofr @kaisalmen