[FEAT] Support sandbox mode: allow reinitializing the workbench #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 6, 2025 11:09
while mouting a parent frame container
CGNonofr
requested review from
MaximeCheramy,
kaisalmen,
onora-hbl and
samuel-olivier
samuel-olivier
approved these changes
Aug 7, 2025
|
🎉 This PR is included in version 19.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #651
The global idea is to run all the code in an iframe, while still be manipulating the dom of the top window
It allows to remove the iframe and cleanup everything and then be able to reinitialize it with different options
The demo showcases it with: