Skip to content

feat: add a way to override onDidChangeFullScreen #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CGNonofr merged 1 commit into from
Nov 21, 2025
Merged

feat: add a way to override onDidChangeFullScreen #739

CGNonofr merged 1 commit into from
Nov 21, 2025

Conversation

@JeanDamien
Copy link
Contributor

@JeanDamien JeanDamien commented Nov 20, 2025 •
edited
Loading

Make it possible to provide a onDidChangeFullScreen event

    ...getHostServiceOverride({
      onDidChangeFullScreen: emitter.event,
      toggleFullScreen: async () => {
         // Request fullscreen on our own dom element
      }
    })

that we can call when the parent app is managing fullscreen, to be able to sync the internal state of vscode

@JeanDamien JeanDamien requested a review from CGNonofr November 20, 2025 17:12
@JeanDamien JeanDamien self-assigned this Nov 20, 2025
@JeanDamien JeanDamien force-pushed the jtx/feat-allow-removing-fullscreen-menus branch from b99ae6a to ea00ca0 Compare November 20, 2025 18:14
@JeanDamien JeanDamien changed the title feat: add context key to remove fullscreen toggle menu and keybindings feat: add a way to override onDidChangeFullScreen Nov 20, 2025
CGNonofr
CGNonofr approved these changes Nov 21, 2025
View reviewed changes
Copy link
Contributor

@CGNonofr CGNonofr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CGNonofr CGNonofr merged commit 09a7f2e into main Nov 21, 2025
2 checks passed
@CGNonofr CGNonofr deleted the jtx/feat-allow-removing-fullscreen-menus branch November 21, 2025 09:23
@github-actions
Copy link

github-actions bot commented Nov 21, 2025

🎉 This PR is included in version 23.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CGNonofr CGNonofr CGNonofr approved these changes

Assignees

@JeanDamien JeanDamien

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JeanDamien @CGNonofr