Skip to content

Fix standalone languages #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CGNonofr merged 2 commits into from
Nov 26, 2025
Merged

Fix standalone languages #744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cfba00
fix: wrong manifest entrypoint
Nov 25, 2025
2e5a6ab
fix: properly bundle standalone monarch languages
Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions monaco-patches/0003-fix-add-basic-language-contribution-as-entry.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Mangeonjean?= <[email protected]>
Date: Tue, 25 Nov 2025 19:06:58 +0100
Subject: [PATCH] fix: add basic language contribution as entry

to make sure it exists in the output
---
build/esm/rollup.config.mjs | 1 +
1 file changed, 1 insertion(+)

diff --git a/build/esm/rollup.config.mjs b/build/esm/rollup.config.mjs
index 37b08bd5..1e18bb2f 100644
--- a/build/esm/rollup.config.mjs
+++ b/build/esm/rollup.config.mjs
@@ -27,6 +27,7 @@ export default defineConfig({
edcoreMain: join(root, './src/editor/edcore.main.ts'),
editorApi: join(root, './src/editor/editor.api.ts'),
editorWorker: join(root, './src/editor/editor.worker.ts'),
+ basiclanguages: join(root, './src/basic-languages/monaco.contribution.ts'),
...getNlsEntryPoints(),
},

12 changes: 4 additions & 8 deletions rollup/rollup.monaco.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,8 @@ export default rollup.defineConfig([
default: './' + worker
}
},
main: 'index.js',
module: 'index.js',
main: './' + main,
module: './' + main,
dependencies: {
'monaco-editor': `npm:${EDITOR_API_PACKAGE_NAME}@^${pkg.version}`,
...dependencies
Expand All @@ -215,13 +215,9 @@ export default rollup.defineConfig([
]
}
})
)),
{
)), {
input: {
index: path.resolve(BASIC_LANGUAGE_DIR, '_.contribution.js')
},
treeshake: {
preset: 'smallest'
index: path.resolve(BASIC_LANGUAGE_DIR, 'monaco.contribution.js')
},
output: {
minifyInternalExports: false,
Expand Down