FIX: Fixed bad parsing of binary request bodies #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodingAleCR
approved these changes
Apr 21, 2025
Owner
|
@allcontributors add @iruizr7 for code |
Contributor
|
I've put up a pull request to add @iruizr7! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code always assumed that request's bodies were UTF-8 parseable.
This change allows
bodycopying when possible, but unblocks request which does not have a UTF-8 decodable body.For the rest of use-cases, for example, when only introducing some headers,
bodyBytespasses unmodified and thebodygetter is never called, and a UTF-8 decoding exception avoided.