Skip to content

Conversation

chkpnt
Copy link

@chkpnt chkpnt commented Mar 4, 2015

Particularly, the InstrumentedDemoRunner should be launchable out of the box.

@CodingFabian
Copy link
Owner

I would not like to include such launch configurations. they break all the time.
Also please use separate branches for PRs, otherwise subsequent PRs will contain older commits.

@chkpnt
Copy link
Author

chkpnt commented Mar 4, 2015

It's your decision to include something or not, as it's your repository :-)

As an alternative to commit launch configurations, it is possible to generate them (InstrumentedDemoRunner is the only relevent one) by having a corresponding pom.xml-entry, so everything is in one place, and the launch configuration is generated only when using Eclipse.

An other alternative would be to go without the runner classes at all, and instead using JUnit. In this case, the AspectJ-agent can be set through the surefire-plugin. Drawback: The "tests" have to be run via Maven.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants