Skip to content

Conversation

@Real-MullaC
Copy link

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

Testing

Impact

Issue related to PR

  • Resolves #

Additional Information

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@CodingWonders
Copy link
Owner

@MyDrift-user, it may be a good idea if you check this as well

@CodingWonders
Copy link
Owner

@Real-MullaC, your vibe-coding session really did something

@Real-MullaC
Copy link
Author

@Real-MullaC, your vibe-coding session really did something

I know and it works

Copy link
Owner

@CodingWonders CodingWonders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, these may work, but AI is bastardizing the code now with unnecessary debug statements, security principal modification, and all of that; for something DISM doesn't need.

@CodingWonders CodingWonders marked this pull request as draft August 5, 2025 19:05
@CodingWonders
Copy link
Owner

@Real-MullaC, I can't accept this in its current state because, even though you have good intentions with this PR (something @MyDrift-user and I struggled to get working), it is hopeless with all of this AI slop. I recommend that you fix most of these annoyances (using too many Windows APIs, creating lots of structures, messing with NT security privileges, rolling with stuff that is utterly misinformed like a DISM service...)

And, start using Notepad++ to avoid this AI slop in the future.

@MyDrift-user
Copy link

I think AI can be used in a good way, but those are too many new files for essencially an already existing but not implemented feature. I'd suggest you take a look on how it actually works and does things. then make a new branch based of main and try to implement it into the current infrastructure. cleaning up AI slop is way harder than just doing it yourself and it will come out better most of the times.

@CodingWonders
Copy link
Owner

@MyDrift-user, I agree. I was in the middle of reviewing this new code. This is like I said in yesterday's reviews. I believe this is too much. I'm going to finish those reviews.

Copy link
Owner

@CodingWonders CodingWonders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better but still a bit hopeless.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this even used?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What?

@CodingWonders
Copy link
Owner

@Real-MullaC, there's your review for now. Answer the review comments

Real-MullaC and others added 4 commits August 6, 2025 08:20
Co-authored-by: CodingWonders <101426328+CodingWonders@users.noreply.github.com>
Co-authored-by: CodingWonders <101426328+CodingWonders@users.noreply.github.com>
@CodingWonders
Copy link
Owner

@Real-MullaC, just to inform you, I won't check commits for some time as I'm also working on my projects, and currently, whatever Agent mode is spitting at you is backfiring.

I really am having a hard time checking all the mistakes AI is making.

@CodingWonders CodingWonders added the longhorn Something broken and unmaintainable. The least wanted state. This includes unmaintainable AI slop. label Aug 6, 2025
@CodingWonders
Copy link
Owner

This PR will be closed to sync this fork with upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

longhorn Something broken and unmaintainable. The least wanted state. This includes unmaintainable AI slop.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants