-
Notifications
You must be signed in to change notification settings - Fork 0
Runspace #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runspace #9
Conversation
|
@MyDrift-user, it may be a good idea if you check this as well |
|
@Real-MullaC, your vibe-coding session really did something |
I know and it works |
CodingWonders
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, these may work, but AI is bastardizing the code now with unnecessary debug statements, security principal modification, and all of that; for something DISM doesn't need.
|
@Real-MullaC, I can't accept this in its current state because, even though you have good intentions with this PR (something @MyDrift-user and I struggled to get working), it is hopeless with all of this AI slop. I recommend that you fix most of these annoyances (using too many Windows APIs, creating lots of structures, messing with NT security privileges, rolling with stuff that is utterly misinformed like a DISM service...) And, start using Notepad++ to avoid this AI slop in the future. |
It's empty and not needed
|
I think AI can be used in a good way, but those are too many new files for essencially an already existing but not implemented feature. I'd suggest you take a look on how it actually works and does things. then make a new branch based of main and try to implement it into the current infrastructure. cleaning up AI slop is way harder than just doing it yourself and it will come out better most of the times. |
|
@MyDrift-user, I agree. I was in the middle of reviewing this new code. This is like I said in yesterday's reviews. I believe this is too much. I'm going to finish those reviews. |
CodingWonders
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better but still a bit hopeless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this even used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What?
|
@Real-MullaC, there's your review for now. Answer the review comments |
Co-authored-by: CodingWonders <101426328+CodingWonders@users.noreply.github.com>
Co-authored-by: CodingWonders <101426328+CodingWonders@users.noreply.github.com>
|
@Real-MullaC, just to inform you, I won't check commits for some time as I'm also working on my projects, and currently, whatever Agent mode is spitting at you is backfiring. I really am having a hard time checking all the mistakes AI is making. |
|
This PR will be closed to sync this fork with upstream. |
Type of Change
Description
Testing
Impact
Issue related to PR
Additional Information
Checklist