fix: Modify variable names and error messages

Co-authored-by: Chris Ohk <[email protected]>

Author: reddevilmidzy

src/file_manager/handlers.rs

@@ -24,7 +24,7 @@ pub async fn upload_file(
     Path((problem_id, category)): Path<(u32, String)>,
     multipart: Multipart,
 ) -> impl IntoResponse {
-    let (file_name, data) = match extract_multipart_data(multipart).await {
+    let (filename, data) = match extract_multipart_data(multipart).await {
         Ok(data) => data,
         Err(e) => {
             return (
@@ -42,20 +42,20 @@ pub async fn upload_file(
         .join(problem_id.to_string())
         .join(&category);
 
-    let file_path = upload_dir.join(&file_name);
+    let file_path = upload_dir.join(&filename);
 
     if file_exists(&file_path).await {
         return (
             StatusCode::CONFLICT,
             Json(serde_json::json!({
-                "error": format!("File '{}' already exists in this category", file_name)
+                "error": format!("File '{filename}' already exists in this category")
             })),
         )
             .into_response();
     }
 
     let now = Utc::now();
-    let language = match Language::from_filename(&file_name) {
+    let language = match Language::from_filename(&filename) {
         Ok(lang) => lang,
         Err(e) => {
             return (
@@ -80,7 +80,7 @@ pub async fn upload_file(
 
     let metadata = FileMetadata {
         id: file_id,
-        filename: file_name,
+        filename: filename,
         language: language,
         category: category,
         size: data.len() as u64,
@@ -112,14 +112,14 @@ async fn extract_multipart_data(mut multipart: Multipart) -> Result<(String, axu
         .await?
         .ok_or_else(|| anyhow!("Missing multipart field"))?;
 
-    let file_name = field
+    let filename = field
         .file_name()
-        .ok_or_else(|| anyhow!("Missing file name in multipart field"))?
+        .ok_or_else(|| anyhow!("Missing filename in multipart field"))?
         .to_string();
 
     let data = field.bytes().await?;
 
-    Ok((file_name, data))
+    Ok((filename, data))
 }
 
 pub async fn get_file(
@@ -134,7 +134,7 @@ pub async fn get_file(
         return (
             StatusCode::NOT_FOUND,
             Json(serde_json::json!({
-                "error": format!("File '{}' not found in category '{}'", filename, category)
+                "error": format!("File '{filename}' not found in category '{category}'")
             })),
         )
             .into_response();
@@ -172,7 +172,7 @@ pub async fn get_files_by_category(
         return (
             StatusCode::NOT_FOUND,
             Json(serde_json::json!({
-                "error": format!("Category '{}' not found for problem {}", category, problem_id)
+                "error": format!("Category '{category}' not found for problem {problem_id}")
             })),
         )
             .into_response();
@@ -217,7 +217,7 @@ pub async fn delete_file(
         return (
             StatusCode::NOT_FOUND,
             Json(serde_json::json!({
-                "error": format!("File '{}' not found in category '{}'", filename, category)
+                "error": format!("File '{filename}' not found in category '{category}'")
             })),
         )
             .into_response();
@@ -227,7 +227,7 @@ pub async fn delete_file(
         Ok(_) => (
             StatusCode::OK,
             Json(serde_json::json!({
-                "message": format!("File '{}' deleted successfully", filename)
+                "message": format!("File '{filename}' deleted successfully")
             })),
         )
             .into_response(),
@@ -254,7 +254,7 @@ pub async fn update_file_content(
         return (
             StatusCode::NOT_FOUND,
             Json(serde_json::json!({
-                "error": format!("File '{}' not found in category '{}'", filename, category)
+                "error": format!("File '{filename}' not found in category '{category}'")
             })),
         )
             .into_response();
@@ -264,7 +264,7 @@ pub async fn update_file_content(
         Ok(_) => (
             StatusCode::OK,
             Json(serde_json::json!({
-                "message": format!("File '{}' updated successfully", filename)
+                "message": format!("File '{filename}' updated successfully")
             })),
         )
             .into_response(),
@@ -292,8 +292,8 @@ pub async fn update_filename(
             StatusCode::NOT_FOUND,
             Json(serde_json::json!({
                 "error": format!(
-                    "File '{}' not found in category '{}'",
-                    update_request.old_filename, category
+                    "File '{}' not found in category '{category}'",
+                    update_request.old_filename
                 )
             })),
         )

src/file_manager/models.rs

@@ -33,7 +33,7 @@ impl std::fmt::Display for LanguageError {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         match self {
             LanguageError::UnsupportedExtension(extension) => {
-                write!(f, "Unsupported file extension: {}", extension)
+                write!(f, "Unsupported file extension: {extension}")
             }
             LanguageError::InvalidFilename => write!(f, "Invalid filename"),
         }