Added check to maintain definitions after subsequent imports.#22
Open
jordanyaker wants to merge 1 commit intoCoffa:masterfrom
Open
Added check to maintain definitions after subsequent imports.#22jordanyaker wants to merge 1 commit intoCoffa:masterfrom
jordanyaker wants to merge 1 commit intoCoffa:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using FactoryGirl on a project involving polymer.js and are defining factories in different components. For any component where we import two or more factories, the last import was the only set of definitions that "took".
Given that two components (i.e.,
xh-data-eventsandxh-api-device) both import factory_girl.js, if you have the following snippet of code:The second import will cause another import of factory_girl.js. This would in-turn cause the re-initialization of the
FactoryGirlglobal module and the loss of any definitions that were made as part ofxh-data-events.Adding a simple check to the compilation template files remedies this problem. Additionally, the use of the lazy logic initializers (i.e.,
foo && bar || rab) will ensure that FactoryGirl is initialized at this level no matter what.