Added pinch gestures #29
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic implementation enables one shot pinch gesture. That is the command from config file will run only once as soon as fingers move 50% the distance between the fingers.
I felt that pinch gesture is kinda tricky to execute on touchpad, so I changed a way of calculation when to trigger the command and added the distance for fingers travel to configuration. Basically a `0.5` distance feels quite ok to me, but it becomes really snappy at `0.1`.
Added a configurable distance variable to pinch gesture.
|
I've been anticipating the pinch gestures since #10 was submitted. Does this answer the concerns given there? |
|
@yigitsever in my current implementation I ignore fingers count as this was mainly implemented just for myself and all I need is punch in and out. Anyway I'll try to look into that, no promises tho :-) |
|
@yigitsever per what I see from my test fingers detection is quite reliable and mistakes are rare. |
|
angle delta also works but it is a bit tricky, i'll ignore it for now |
|
Closing in favor of #30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic implementation enables one shot pinch gesture.
That is the command from config file will run only once as soon as
fingers move 50% the distance between the fingers.