Reuse name input logic and allow retry in data path input#6696
Open
Jackenmen wants to merge 1 commit intoCog-Creators:V3/developfrom
Open
Reuse name input logic and allow retry in data path input#6696Jackenmen wants to merge 1 commit intoCog-Creators:V3/developfrom
Jackenmen wants to merge 1 commit intoCog-Creators:V3/developfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes
get_name()has been updated to ask whether to overwrite the instance since it's done in both places it's calledget_data_dir()will now continue to reask in a loop until it gets a valid path instead of exitingHave the changes in this PR been tested?
Yes