Skip to content

fix: Helm Medcat service should exit 1 on failure #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

fix: Helm Medcat service should exit 1 on failure #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion deployment/kubernetes/charts/medcat-service-helm/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,11 @@ spec:
echo "Downloading model $MODEL_NAME from $MODEL_PACK_URL"
mkdir -p /models
wget -O "/models/$MODEL_NAME" "$MODEL_PACK_URL"
echo "Download finished"
if [ $? -ne 0 ]; then
echo "Failed to download model from $MODEL_PACK_URL" >&2
exit 1
fi
echo "Download finished successfully"
env:
- name: MODEL_PACK_URL
value: {{ .Values.model.downloadUrl}}
Expand Down
Loading