Skip to content

Upgraded all the libraries in the world#24

Closed
Guidoooch wants to merge 12 commits intoColOfAbRiX:masterfrom
Guidoooch:Upgrade-Scalafix-and-Scala-2.13-and-2.12
Closed

Upgraded all the libraries in the world#24
Guidoooch wants to merge 12 commits intoColOfAbRiX:masterfrom
Guidoooch:Upgrade-Scalafix-and-Scala-2.13-and-2.12

Conversation

@Guidoooch
Copy link
Copy Markdown

@Guidoooch Guidoooch commented Sep 22, 2024

Proposed changes

Fixes many things, including but not limited to:
#18

Many tests do not compile in Scala 2.12, this PR fixes that too.

Types of changes

What types of changes does your code introduce to Figlet4s?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@q-guidomaresca q-guidomaresca force-pushed the Upgrade-Scalafix-and-Scala-2.13-and-2.12 branch from f7696f0 to 57d0e07 Compare September 23, 2024 08:30
@ColOfAbRiX
Copy link
Copy Markdown
Owner

Libraries upgrade will be performed in #26

@ColOfAbRiX ColOfAbRiX closed this Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants