feat: manual PR fallback and branch-aligned create-pr flow#69
feat: manual PR fallback and branch-aligned create-pr flow#69ColeMurray merged 5 commits intomainfrom
Conversation
* Add Slack manual PR fallback with Create PR button * Address PR review feedback for manual PR flow * Harden manual PR fallback and artifact parsing
* refactor: isolate github provider factory and push-spec builders * feat: align create-pr branch flow with pushed branch
* refactor: isolate github provider factory and push-spec builders * feat: align create-pr branch flow with pushed branch * fix: tighten slack manual-pr artifact detection
Terraform Validation Results
Pushed by: @ColeMurray, Action: |
Greptile OverviewGreptile Summary
|
Additional Comments (1)
Prompt To Fix With AIThis is a comment left during a code review.
Path: packages/control-plane/src/session/durable-object.ts
Line: 2363:2373
Comment:
**Always force-pushing branches**
`handleCreatePR` builds the `pushSpec` with `force: true`, which will overwrite the remote branch if it already exists. This can destroy work if someone reused the same `headBranch` (especially now that `headBranch` can come from the client’s current branch). Unless you *require* force pushes for this flow, this should be `false` (or conditional only for the generated session branch).
How can I resolve this? If you propose a fix, please make it concise. |
Terraform Validation Results
Pushed by: @ColeMurray, Action: |
Summary
This PR consolidates manual PR fallback and branch-alignment improvements for create-pr.
Key outcomes:
create-praccepts optionalheadBranchand resolves branch deterministicallypushSpecso pushed branch and PR branch stay alignedpull/newURL when user OAuth is unavailableValidation
npm run build -w @open-inspect/sharednpm run typechecknpm run test -w @open-inspect/control-planenpm run test -w @open-inspect/slack-bot -- run