You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note: Terraform plan was skipped because secrets are not configured. This is expected for external contributors. See docs/GETTING_STARTED.md for setup instructions.
This PR establishes a clean architectural foundation for source control provider abstraction with single-provider-per-deployment constraints. The implementation adds deployment-level SCM_PROVIDER configuration (defaulting to github), routes provider selection through a factory with explicit 501 Not Implemented responses for unimplemented providers on non-public routes, and documents the single-provider boundaries through an ADR and contribution checklist.
Added resolveScmProviderFromEnv() function that normalizes provider names and validates against supported values (github, bitbucket)
Modified router to enforce provider implementation check via enforceImplementedScmProvider() middleware
Updated createSourceControlProvider() factory to throw explicit errors for bitbucket (not yet implemented) vs unknown providers
Added comprehensive tests for provider resolution and factory behavior
Created ADR 0001 documenting the single-provider deployment decision and boundary rules
Added provider contribution checklist to guide future SCM integrations
Note: Terraform plan was skipped because secrets are not configured. This is expected for external contributors. See docs/GETTING_STARTED.md for setup instructions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SCM_PROVIDERresolution with a default ofgithub501for unimplemented providers on non-public routesValidation
npm run typecheck -w @open-inspect/control-planenpm -w @open-inspect/control-plane exec vitest run src/source-control/config.test.ts src/source-control/providers/index.test.ts