-
Notifications
You must be signed in to change notification settings - Fork 32
Docs: use GCC 12 explicitly in Collabora Office Linux build #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Collabora Office Linux build documentation to explicitly specify GCC/G++ version 12 in the build configuration command, aligning with LibreOffice core compiler requirements.
- Adds explicit compiler version specification using environment variables in the configure command
- Prefixes the configure command with
CC="ccache gcc-12" CXX="ccache g++-12"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hii @pedropintosilva I have Created PR for the doc .Please review . |
Darshan-upadhyay1110
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@omkarhole thanks for the PR. Happy to see you are updating the documentation :)
CC="ccache gcc-12" CXX="ccache g++-12" are optional and only needed if you want to force a specific compiler and/or use ccache.
so i am not sure we should force this instruction here.....
Darshan-upadhyay1110
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @omkarhole ,
I see that Pedro has already filed the issue
@omkarhole could you please update your description and add the link to the issue, so it is automatically visible from the GitHub interface?
Also, I noticed that the changes were made to the Collabora Office instructions, which is not correct. The task is specifically about updating the Collabora Online build instructions, and more precisely for openSUSE.
The task mentions:
“Add CC="ccache gcc-12" CXX="ccache g++-12" flags to the ./configure line under building online for each distro, if needed.”
Please check, apart from openSUSE, which other distributions actually require this update, and whether it makes sense to add it for them.
The page that needs to be updated is:
https://collaboraonline.github.io/post/build-code/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@omkarhole the blurish effect is not looking good here can e change it ? just a simple note before or after the ./config section would be good...
|
@Darshan-upadhyay1110 I have make changes as per your request please check it ! |
Darshan-upadhyay1110
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@omkarhole have you tested this patch with Open Suse ? Although i see this instruction very confusing....
as you can see in image the ./config command mentioned twice there so will that work expected or will the gcc override with the second one ?
anyways if you have tested and it is working then let me know.
This updates the Collabora Office Linux build documentation to explicitly
use GCC/G++ 12 by prefixing the configure command with:
CC="ccache gcc-12" CXX="ccache g++-12"
This aligns the Collabora Office build instructions with the documented
LibreOffice core compiler requirements.
Issue: #125