Open
Conversation
caolanm
force-pushed
the
private/caolan/missing_groupbutton_shortcuts
branch
from
0094414 to
6bd44f5
Compare
In the calc Data notebookbar tab, there is no shortcut for Group. probably since: commit 7e83016 Date: Wed Aug 6 15:24:33 2025 +0530 feat: Implement group labels and overflow management in Calc notebookbar The overflow group data-group and its bigtoolitem child shared the same id. When the accessibility code processes the bigtoolitem, querySelector('#data-group.ui-overflow-group') matches the parent overflow group instead of finding the button, so the Group button's shortcut is never registered. Add a test for this and fix the other cases found in the other apps that were not yet audited. Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: Iec07a2722de4e0bde24881389df7aa47af1ec06b
caolanm
force-pushed
the
private/caolan/missing_groupbutton_shortcuts
branch
from
6bd44f5 to
8ca17ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay